From: Theodore Ts'o <tytso@mit.edu>
To: linux-ext4@vger.kernel.org
Cc: Girish.Shilamkar@Sun.COM, adilger@sun.com,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger@clusterfs.com>,
Girish Shilamkar <girish@clusterfs.com>
Subject: [PATCH] jbd2: Fix memory leak when verifying checksums in the journal
Date: Wed, 4 Jun 2008 19:56:33 -0400 [thread overview]
Message-ID: <1212623794-10183-1-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <20080604234057.GA9641@mit.edu>
Cc: Andreas Dilger <adilger@clusterfs.com>
Cc: Girish Shilamkar <girish@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
fs/jbd2/recovery.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/jbd2/recovery.c b/fs/jbd2/recovery.c
index 5d0405a..7199db5 100644
--- a/fs/jbd2/recovery.c
+++ b/fs/jbd2/recovery.c
@@ -344,6 +344,7 @@ static int calc_chksums(journal_t *journal, struct buffer_head *bh,
*crc32_sum = crc32_be(*crc32_sum, (void *)obh->b_data,
obh->b_size);
}
+ put_bh(obh);
}
return 0;
}
--
1.5.4.1.144.gdfee-dirty
next prev parent reply other threads:[~2008-06-04 23:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-24 22:34 What to do when the journal checksum is incorrect Theodore Ts'o
2008-05-25 6:30 ` Andreas Dilger
2008-05-25 11:38 ` Theodore Tso
2008-05-26 14:54 ` Theodore Tso
2008-05-26 18:24 ` Andreas Dilger
2008-05-26 21:28 ` Ric Wheeler
2008-06-03 10:22 ` Girish Shilamkar
2008-06-03 21:27 ` Andreas Dilger
2008-06-04 23:40 ` Theodore Tso
2008-06-04 23:56 ` Theodore Ts'o [this message]
2008-06-04 23:56 ` [PATCH] jbd2: If a journal checksum error is detected, propagate the error to ext4 Theodore Ts'o
2008-06-05 3:17 ` Andreas Dilger
2008-06-05 16:21 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1212623794-10183-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=Girish.Shilamkar@Sun.COM \
--cc=adilger@clusterfs.com \
--cc=adilger@sun.com \
--cc=girish@clusterfs.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).