From: Mingming Cao <cmm@us.ibm.com>
To: Andreas Dilger <adilger@sun.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>, "Theodore Ts'o" <tytso@mit.edu>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext3: kill 2 useless magic numbers
Date: Thu, 12 Jun 2008 16:11:34 -0700 [thread overview]
Message-ID: <1213312294.3698.30.camel@localhost.localdomain> (raw)
In-Reply-To: <20080612063847.GR3726@webber.adilger.int>
On Thu, 2008-06-12 at 00:38 -0600, Andreas Dilger wrote:
> On Jun 12, 2008 09:18 +0800, Li Zefan wrote:
> > dx_root_limit() will never return 20, and I can't figure out
> > what 20 stands for. This function has never changed since htree
> > directory indexing was merged.
> >
> > Similar for dx_node_limit() and the magic 22.
>
> This was for testing htree split code more aggressively, but can be
> removed.
>
> Acked-by: Andreas Dilger <adilger@sun.com>
I added the ext4 version to the patch queue
Mingming
>
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> > ---
> > fs/ext3/namei.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
> > index 0b8cf80..d282ea8 100644
> > --- a/fs/ext3/namei.c
> > +++ b/fs/ext3/namei.c
> > @@ -240,13 +240,13 @@ static inline unsigned dx_root_limit (struct inode *dir, unsigned infosize)
> > {
> > unsigned entry_space = dir->i_sb->s_blocksize - EXT3_DIR_REC_LEN(1) -
> > EXT3_DIR_REC_LEN(2) - infosize;
> > - return 0? 20: entry_space / sizeof(struct dx_entry);
> > + return entry_space / sizeof(struct dx_entry);
> > }
> >
> > static inline unsigned dx_node_limit (struct inode *dir)
> > {
> > unsigned entry_space = dir->i_sb->s_blocksize - EXT3_DIR_REC_LEN(0);
> > - return 0? 22: entry_space / sizeof(struct dx_entry);
> > + return entry_space / sizeof(struct dx_entry);
> > }
> >
> > /*
> > --
> > 1.5.4.rc3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Cheers, Andreas
> --
> Andreas Dilger
> Sr. Staff Engineer, Lustre Group
> Sun Microsystems of Canada, Inc.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-06-12 23:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-12 1:18 [PATCH 1/2] ext3: kill 2 useless magic numbers Li Zefan
2008-06-12 6:38 ` Andreas Dilger
2008-06-12 23:11 ` Mingming Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213312294.3698.30.camel@localhost.localdomain \
--to=cmm@us.ibm.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ext4@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).