linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frédéric Bohé" <frederic.bohe@bull.net>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: fix online resize group descriptors corruption
Date: Fri, 13 Jun 2008 14:33:43 +0200	[thread overview]
Message-ID: <1213360423.9222.41.camel@localhost> (raw)
In-Reply-To: <20080612190427.GD18229@mit.edu>

Ted,

Concerning flex_bg and uninit_bg : it's currently not possible to resize
a filesystem with those features. It seems there are issues with
resize2fs.
We have also used nomballoc switch when mounting because of the oops
when unmounting.

We have tried both physical hard disk drive and loop back devices.
We have tested several filesystem resize with few (adding 1 group) to
many (adding 250 groups) more groups. All give correct group descriptors
using dump2fs and no problem when writing files and unmounting
filesystems.

This is a typical test case:

mkfs.ext4 -E test_fs -O ^flex_bg /dev/sdc1 10M
mount -t ext4dev -o nomballoc /dev/sdc1 /mnt/test
dumpe2fs /dev/sdc1
resize2fs /dev/sdc1 100M
dumpe2fs /dev/sdc1
dd if=/dev/urandom of=/mnt/test/data bs=95M count=1
umount /mnt/test
fsck.ext4 -f /dev/sdc1

This test being run for several sizes of filesystem (from 10M with 1K
blocks to 1G with 4K blocks).

Let me know if we have missed something or if you want more testings.

Regards




Le jeudi 12 juin 2008 à 15:04 -0400, Theodore Tso a écrit :
> On Thu, Jun 12, 2008 at 11:42:34AM +0200, Frédéric Bohé wrote:
> > From: Frederic Bohe <frederic.bohe@bull.net>
> 
> Frederic,
> 
> Many thanks!  How much testing have you done with the patch?  Does it
> fix growing the filesystems from a filesystem with say, 18 block
> groups to 32 block groups?  Have you tried with with different
> filesystem features, including with and without flex_bg and uninit_bg?
> 
> Regards,
> 
> 	   	     	       	    			- Ted
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2008-06-13 12:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12  9:42 [PATCH] ext4: fix online resize group descriptors corruption Frédéric Bohé
2008-06-12 10:59 ` Andreas Dilger
2008-06-12 13:35   ` [PATCH v2] " Frédéric Bohé
2008-06-12 14:14     ` [PATCH v3] " Frédéric Bohé
2008-06-12 14:56   ` [PATCH] " Jean-Pierre Dion
2008-06-12 19:04 ` Theodore Tso
2008-06-13 12:33   ` Frédéric Bohé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1213360423.9222.41.camel@localhost \
    --to=frederic.bohe@bull.net \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).