From: Theodore Ts'o <tytso@mit.edu>
To: linux-ext4@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] resize2fs: Prohibit the combination of flex_bg and !resize_inode
Date: Tue, 17 Jun 2008 02:06:32 -0400 [thread overview]
Message-ID: <1213682792-4878-4-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1213682792-4878-3-git-send-email-tytso@mit.edu>
This is a potentially a difficult case for resize2fs to handle, so
prohibit it for now.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
resize/main.c | 21 ++++++++++++++++++++-
1 files changed, 20 insertions(+), 1 deletions(-)
diff --git a/resize/main.c b/resize/main.c
index d7097ad..1cb0b20 100644
--- a/resize/main.c
+++ b/resize/main.c
@@ -316,9 +316,28 @@ int main (int argc, char ** argv)
"(%s)", device_name);
exit(1);
}
+
+ /*
+ * XXXX The combination of flex_bg and !resize_inode causes
+ * major problems for resize2fs, since when the group descriptors
+ * grow in size this can potentially require multiple inode
+ * tables to be moved aside to make room, and resize2fs chokes
+ * rather badly in this scenario. It's a rare combination,
+ * except when a filesystem is expanded more than a certain
+ * size, so for now, we'll just prohibit that combination.
+ * This is something we should fix eventually, though.
+ */
+ if ((fs->super->s_feature_incompat & EXT4_FEATURE_INCOMPAT_FLEX_BG) &&
+ !(fs->super->s_feature_compat & EXT2_FEATURE_COMPAT_RESIZE_INODE)) {
+ com_err(program_name, 0, _("%s: The combination of flex_bg "
+ "and\n\t!resize_inode features "
+ "is not supported by resize2fs.\n"),
+ device_name);
+ exit(1);
+ }
if (print_min_size) {
- printf("Estimated minimum size of the filesystem: %u\n",
+ printf(_("Estimated minimum size of the filesystem: %u\n"),
calculate_minimum_resize_size(fs));
exit(0);
}
--
1.5.6.rc3.1.g36b7.dirty
next prev parent reply other threads:[~2008-06-17 6:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-17 6:06 e2fsprogs: Patches to resize2fs Theodore Ts'o
2008-06-17 6:06 ` [PATCH] resize2fs: Fix support for the uninit_bg feature Theodore Ts'o
2008-06-17 6:06 ` [PATCH] ext2fs_zero_blocks: Avoid clearing more blocks than requested Theodore Ts'o
2008-06-17 6:06 ` Theodore Ts'o [this message]
2008-06-17 15:16 ` [PATCH] resize2fs: Fix support for the uninit_bg feature Andreas Dilger
2008-06-17 16:30 ` Theodore Tso
2008-06-23 20:42 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213682792-4878-4-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox