From: Mingming Cao <cmm@us.ibm.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] remove write-only variables from ext4_ordered_write_end
Date: Thu, 31 Jul 2008 11:09:16 -0700 [thread overview]
Message-ID: <1217527756.6317.8.camel@mingming-laptop> (raw)
In-Reply-To: <4891FD21.2000704@redhat.com>
在 2008-07-31四的 12:57 -0500，Eric Sandeen写道：
> from & to are unused.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Acked-by: Mingming Cao <cmm@us.ibm.com>
>
> Index: linux-2.6/fs/ext4/inode.c
> ===================================================================
> --- linux-2.6.orig/fs/ext4/inode.c 2008-07-31 12:38:45.000000000 -0500
> +++ linux-2.6/fs/ext4/inode.c 2008-07-31 12:55:59.181165399 -0500
> @@ -1336,12 +1336,8 @@ static int ext4_ordered_write_end(struct
> {
> handle_t *handle = ext4_journal_current_handle();
> struct inode *inode = mapping->host;
> - unsigned from, to;
> int ret = 0, ret2;
>
> - from = pos & (PAGE_CACHE_SIZE - 1);
> - to = from + len;
> -
> ret = ext4_jbd2_file_inode(handle, inode);
>
> if (ret == 0) {
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-07-31 18:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 17:57 [PATCH] remove write-only variables from ext4_ordered_write_end Eric Sandeen
2008-07-31 18:09 ` Mingming Cao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217527756.6317.8.camel@mingming-laptop \
--to=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox