Re: [PATCH] filesystems: use has_capability_noaudit interface for reserved blocks checks

Andrew Morton
2008-11-13T22:56:09Z

On Tue, 11 Nov 2008 14:12:49 -0500
Eric Paris <eparis@redhat.com> wrote:

> ext[2,3,4], ufs, and ubifs all check for CAP_SYS_RESOURCE to determine
> if they should allow reserved blocks to be used. A process not having
> this capability is not failing some security decision and should not be
> audited. Thus move to using has_capability_noaudit.
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
> ---
>
> I would like to push this patch through the security tree (since that's
> the only place the new cap_noaudit interface exists), but I'd like to
> get an ACK from each subsystem maintainer.

OK by me.

Whoever added has_capability_noaudit() forgot to document it, so the
difference between has_capability_noaudit() and has_capability() eludes
this reader.