From: "Duane Griffin" <duaneg@dghda.com>
To: akpm@linux-foundation.org
Cc: Andreas Dilger <adilger@sun.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/6][REPOST] ext{2,3,4}: tighten inheritance and setting of inode flags
Date: Wed, 3 Dec 2008 19:54:57 +0000 [thread overview]
Message-ID: <1228334103-15948-1-git-send-email-duaneg@dghda.com> (raw)
This patch series prevents the inheritance and setting of flags that are
inappropriate for specific inode types.
Flags which should be inherited are listed explicitly so as to prevent
future flags being overlooked and inherited by accident.
It introduces a function to mask flags based on the inode type and uses
it in inode creation and the SETFLAGS ioctl to help prevent future
inconsistency.
Patches 1-3 fix the TOPDIR flag inheritance bug reported at
http://bugzilla.kernel.org/show_bug.cgi?id=9866.
Patches 4-6 fix a related problem with non-regular file/dir inodes
inheriting inappropriate flags, discovered while testing. For example,
on an unpatched system, the following sequence will create an
un(re)movable device node:
mkdir a
chattr +a a
touch a/a
mknod a/b c 1 3
chattr -a a a/a
All attempts to delete, move or modify a/b will fail. Fsck will report
there is a problem but will not fix it.
Diffstat from linux-next:
fs/ext2/ialloc.c | 8 ++------
fs/ext2/ioctl.c | 3 +--
fs/ext3/ialloc.c | 8 ++------
fs/ext3/ioctl.c | 3 +--
fs/ext4/ext4.h | 25 +++++++++++++++++++++++++
fs/ext4/ialloc.c | 14 +++++---------
fs/ext4/ioctl.c | 3 +--
include/linux/ext2_fs.h | 24 ++++++++++++++++++++++++
include/linux/ext3_fs.h | 24 ++++++++++++++++++++++++
9 files changed, 85 insertions(+), 27 deletions(-)
next reply other threads:[~2008-12-03 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-03 19:54 Duane Griffin [this message]
2008-12-03 19:54 ` [PATCH 1/6] ext2: don't inherit inappropriate inode flags from parent Duane Griffin
2008-12-03 19:54 ` [PATCH 2/6] ext3: " Duane Griffin
2008-12-03 19:55 ` [PATCH 3/6] ext4: " Duane Griffin
2008-12-03 19:55 ` [PATCH 4/6] ext2: tighten restrictions on inode flags Duane Griffin
2008-12-03 19:55 ` [PATCH 5/6] ext3: " Duane Griffin
2008-12-03 19:55 ` [PATCH 6/6] ext4: " Duane Griffin
2008-12-04 6:39 ` [PATCH 0/6][REPOST] ext{2,3,4}: tighten inheritance and setting of " Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1228334103-15948-1-git-send-email-duaneg@dghda.com \
--to=duaneg@dghda.com \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox