linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: Theodore Tso <tytso@mit.edu>,
	Arjan van de Ven <arjan@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
	Ingo Molnar <mingo@elte.hu>,
	Nick Piggin <nickpiggin@yahoo.com.au>
Subject: Re: kernel BUG at fs/ext/super.c:428
Date: Wed, 14 Jan 2009 20:29:37 +0100	[thread overview]
Message-ID: <1231961377.14825.51.camel@laptop> (raw)
In-Reply-To: <20090114191632.GA13114@linux-os.sc.intel.com>

On Wed, 2009-01-14 at 11:16 -0800, Pallipadi, Venkatesh wrote:
> On Tue, Jan 13, 2009 at 08:40:59PM -0800, Theodore Tso wrote:
> > On Wed, Jan 14, 2009 at 02:48:13AM +0000, Arjan van de Ven wrote:
> > >> Well, Arjan's commit, efaee192: "async: make the final inode deletion
> > >> an asynchronous event", does change how inodes get deleted, and this
> > >> looks like a race where an inode is getting deleted during the umount.
> > >>
> > >> So I would try reverting commit efaee192 and see if it fixes things
> > >> before starting a full bisect...
> > >
> > > the commit is already reverted before rc1
> > >
> > 
> > Ah, right.  I see, the async infrastructure is still in fs/super.c,
> > but the actual code to insert deleted inodes onto the s_async_list was
> > removed in commit b32714b.  Sorry, that confused me.
> > 
> > OK, so assuming that Venkatesh was using something post-rc1, I can't
> > suggest anything other than a full bisect.  Sorry....
> > 
> 
> Below is the result of full bisect
> 
> 38d47c1b7075bd7ec3881141bb3629da58f88dab is first bad commit
> commit 38d47c1b7075bd7ec3881141bb3629da58f88dab
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date:   Fri Sep 26 19:32:20 2008 +0200
> 
>     futex: rely on get_user_pages() for shared futexes
>     
>     On the way of getting rid of the mmap_sem requirement for shared futexes,
>     start by relying on get_user_pages().
>     
>     Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
>     Acked-by: Nick Piggin <nickpiggin@yahoo.com.au>
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> :040000 040000 029e79e0a7421438c2a7437dd210a1acf40b6c29 b581716762c1952c0f515fac642690514e7224b7 M      include
> :040000 040000 5f604b60974dbb9b0ac1a0910234f28c43a5e691 10c576cabe7eae661501ec38861a0f7488d5353b M      kernel

However does a futex change make ext3 crap its pants?

Is there anything more to it than start the machine, and reboot?


  reply	other threads:[~2009-01-14 19:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090110003645.GA16107@linux-os.sc.intel.com>
2009-01-14  0:48 ` kernel BUG at fs/ext/super.c:428 Andrew Morton
2009-01-14  1:44   ` Theodore Tso
2009-01-14  2:48     ` Arjan van de Ven
2009-01-14  4:40       ` Theodore Tso
2009-01-14 19:16         ` Pallipadi, Venkatesh
2009-01-14 19:29           ` Peter Zijlstra [this message]
2009-01-14 19:38             ` Pallipadi, Venkatesh
2009-01-14 19:42               ` Peter Zijlstra
2009-01-14 19:48                 ` Pallipadi, Venkatesh
2009-01-14 21:20             ` Theodore Tso
2009-01-21 20:10               ` Pallipadi, Venkatesh
2009-01-24  7:36                 ` Peter Zijlstra
2009-01-26 16:39                   ` Darren Hart
2009-01-26 16:46                     ` Peter Zijlstra
2009-01-26 17:12                       ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1231961377.14825.51.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@linux.intel.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nickpiggin@yahoo.com.au \
    --cc=tytso@mit.edu \
    --cc=venkatesh.pallipadi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).