linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Jan Kara <jack@suse.cz>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
	Ext4 Developers
Subject: [PATCH RFC] ext3 data=guarded v3
Date: Wed, 15 Apr 2009 13:22:36 -0400	[thread overview]
Message-ID: <1239816159-6868-1-git-send-email-chris.mason@oracle.com> (raw)

Hello everyone,

Here is another version of the data=guarded work for ext3.  The main
difference between this code and yesterday's is the guarded writepage
function now sends any newly allocated block through the old data=ordered code.

This is important because at the time we're walking the buffers, the page
may be unlocked, so we can't trust anything inside the page.  In general,
any allocation done by writepage is to fill a hole, so the old data=ordered
is what we want anyway.

This passed a longer stress test and generally seems to be working.  I
don't think anyone would recommend it as a default for 2.6.30, but it
may be a good idea to have a review party and decide if it is safe enough
to include so people can experiment with it.

Overall diffstat of the series:

 fs/buffer.c                 |   45 ++-
 fs/ext3/Makefile            |    3
 fs/ext3/fsync.c             |   12
 fs/ext3/inode.c             |  546 +++++++++++++++++++++++++++++++++++++++++++-
 fs/ext3/namei.c             |    3
 fs/ext3/ordered-data.c      |  318 +++++++++++++++++++++++++
 fs/ext3/super.c             |   48 +++
 fs/jbd/transaction.c        |    1
 include/linux/buffer_head.h |    3
 include/linux/ext3_fs.h     |   33 ++
 include/linux/ext3_fs_i.h   |   44 +++
 include/linux/ext3_fs_sb.h  |    6
 include/linux/ext3_jbd.h    |   11
 include/linux/jbd.h         |   10
 mm/filemap.c                |    1

-chris



             reply	other threads:[~2009-04-15 17:23 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-15 17:22 Chris Mason [this message]
2009-04-15 17:22 ` [PATCH 1/3] Export filemap_write_and_wait_range Chris Mason
2009-04-15 17:22   ` [PATCH 2/3] Add block_write_full_page_endio for passing endio handler Chris Mason
2009-04-15 17:22   ` [PATCH 3/3] Add ext3 data=guarded mode Chris Mason
2009-04-16 19:42     ` [PATCH] " Chris Mason
2009-04-17 11:04       ` Mike Galbraith
2009-04-17 18:09       ` Amit Shah
2009-04-17 20:13         ` Theodore Tso
2009-04-18  6:03           ` Amit Shah
     [not found]           ` <20090418060312.GA10943@amit-x200.pnq.redhat.com>
2009-04-18  7:28             ` Mike Galbraith
2009-04-19  6:24               ` Amit Shah
2009-04-20  9:07                 ` Mike Galbraith
2009-04-20  9:26                   ` Jan Kara
2009-04-20 12:15                     ` Mike Galbraith
2009-04-20 12:56                       ` Amit Shah
2009-04-20 13:06                         ` Mike Galbraith
2009-04-20 13:44       ` Jan Kara
2009-04-20 14:18         ` Chris Mason
2009-04-20 14:42           ` Jan Kara
2009-04-20 14:58             ` Chris Mason
2009-04-20 15:50               ` Jan Kara
2009-04-15 19:10 ` [PATCH RFC] ext3 data=guarded v3 Eric Sandeen
2009-04-15 20:35 ` Linus Torvalds
2009-04-15 21:09   ` Theodore Tso
2009-04-16  8:44   ` Jan Kara
2009-04-16 18:09   ` Nick Piggin
2009-04-16 11:39 ` Mike Galbraith
2009-04-16 11:40   ` Mike Galbraith
2009-04-16 14:56   ` Chris Mason
2009-04-16 17:12     ` Chris Mason
2009-04-16 18:25       ` Mike Galbraith
2009-04-16 18:37       ` Linus Torvalds
2009-04-16 19:38         ` Chris Mason
2009-04-16 18:00     ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1239816159-6868-1-git-send-email-chris.mason@oracle.com \
    --to=chris.mason@oracle.com \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).