From: Mike Galbraith <efault@gmx.de>
To: Chris Mason <chris.mason@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
Theodore Ts'o <tytso@mit.edu>,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] Add ext3 data=guarded mode
Date: Fri, 17 Apr 2009 13:04:36 +0200 [thread overview]
Message-ID: <1239966276.8806.7.camel@marge.simson.net> (raw)
In-Reply-To: <1239910921.21233.98.camel@think.oraclecorp.com>
On Thu, 2009-04-16 at 15:42 -0400, Chris Mason wrote:
> Hello everyone,
>
> Here's an updated (v4) patch for ext3 data=guarded mode. The first two
> patches in the series are unchanged, and it looks like Linus pulled them
> in this morning.
>
> This version fixes the bug Mike Galbraith hit. The problem was with
> writes to the last block in the file that made the file bigger but
> didn't actually add a new block. Since the block wasn't new, it
> wouldn't get sent through the guarded code and the on disk i_size wasn't
> always updated.
FWIW, I booted my backup fs drive mounted data=guarded, and have been
hammering it steadily since 6 A.M. with no hint of trouble.
-Mike
next prev parent reply other threads:[~2009-04-17 11:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 17:22 [PATCH RFC] ext3 data=guarded v3 Chris Mason
2009-04-15 17:22 ` [PATCH 1/3] Export filemap_write_and_wait_range Chris Mason
2009-04-15 17:22 ` [PATCH 2/3] Add block_write_full_page_endio for passing endio handler Chris Mason
2009-04-15 17:22 ` [PATCH 3/3] Add ext3 data=guarded mode Chris Mason
2009-04-16 19:42 ` [PATCH] " Chris Mason
2009-04-17 11:04 ` Mike Galbraith [this message]
2009-04-17 18:09 ` Amit Shah
2009-04-17 20:13 ` Theodore Tso
2009-04-18 6:03 ` Amit Shah
[not found] ` <20090418060312.GA10943@amit-x200.pnq.redhat.com>
2009-04-18 7:28 ` Mike Galbraith
2009-04-19 6:24 ` Amit Shah
2009-04-20 9:07 ` Mike Galbraith
2009-04-20 9:26 ` Jan Kara
2009-04-20 12:15 ` Mike Galbraith
2009-04-20 12:56 ` Amit Shah
2009-04-20 13:06 ` Mike Galbraith
2009-04-20 13:44 ` Jan Kara
2009-04-20 14:18 ` Chris Mason
2009-04-20 14:42 ` Jan Kara
2009-04-20 14:58 ` Chris Mason
2009-04-20 15:50 ` Jan Kara
2009-04-15 19:10 ` [PATCH RFC] ext3 data=guarded v3 Eric Sandeen
2009-04-15 20:35 ` Linus Torvalds
2009-04-15 21:09 ` Theodore Tso
2009-04-16 8:44 ` Jan Kara
2009-04-16 18:09 ` Nick Piggin
2009-04-16 11:39 ` Mike Galbraith
2009-04-16 11:40 ` Mike Galbraith
2009-04-16 14:56 ` Chris Mason
2009-04-16 17:12 ` Chris Mason
2009-04-16 18:25 ` Mike Galbraith
2009-04-16 18:37 ` Linus Torvalds
2009-04-16 19:38 ` Chris Mason
2009-04-16 18:00 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1239966276.8806.7.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=chris.mason@oracle.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).