From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: cmm@us.ibm.com, tytso@mit.edu, sandeen@redhat.com
Cc: linux-ext4@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [RFC PATCH] mark buffer_head mapping preallocate area as new during write_begin with delayed allocation
Date: Tue, 28 Apr 2009 00:35:43 +0530 [thread overview]
Message-ID: <1240859143-31122-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
We need to mark the buffer_head mapping prealloc space
as new during write_begin. Otherwise we don't zero out the
page cache content properly for a partial write. This will
cause file corruption with preallocation.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
fs/ext4/inode.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index c6bd6ce..c7251ec 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -2323,6 +2323,8 @@ static int ext4_da_get_block_prep(struct inode *inode, sector_t iblock,
set_buffer_delay(bh_result);
} else if (ret > 0) {
bh_result->b_size = (ret << inode->i_blkbits);
+ if (buffer_unwritten(bh_result))
+ set_buffer_new(bh_result);
ret = 0;
}
--
tg: (51bec03..) preallocate_corruption (depends on: ext4_lock_group_conversion)
next reply other threads:[~2009-04-27 19:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 19:05 Aneesh Kumar K.V [this message]
2009-04-27 19:30 ` [RFC PATCH] mark buffer_head mapping preallocate area as new during write_begin with delayed allocation Eric Sandeen
2009-04-27 23:04 ` Mingming Cao
2009-04-28 3:03 ` Eric Sandeen
2009-04-28 4:20 ` Aneesh Kumar K.V
2009-04-28 9:31 ` Aneesh Kumar K.V
2009-04-28 12:48 ` Theodore Tso
2009-04-28 16:35 ` Aneesh Kumar K.V
2009-04-28 17:00 ` Theodore Tso
2009-04-28 18:57 ` Aneesh Kumar K.V
2009-04-28 19:35 ` Eric Sandeen
2009-04-29 11:57 ` Jan Kara
2009-04-29 14:08 ` Eric Sandeen
2009-04-29 18:13 ` Jan Kara
2009-04-29 1:38 ` Mingming
2009-04-28 16:37 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240859143-31122-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).