From: Chris Mason <chris.mason@oracle.com>
To: Mike Galbraith <efault@gmx.de>
Cc: Jan Kara <jack@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Theodore Ts'o" <tytso@mit.edu>,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH RFC] ext3 data=guarded v5
Date: Tue, 28 Apr 2009 14:54:14 -0400 [thread overview]
Message-ID: <1240944854.15136.46.camel@think.oraclecorp.com> (raw)
In-Reply-To: <1240943582.5611.15.camel@marge.simson.net>
On Tue, 2009-04-28 at 20:33 +0200, Mike Galbraith wrote:
> On Tue, 2009-04-28 at 14:04 -0400, Chris Mason wrote:
>
> > This patch adds the delayed i_size update to ext3, along with a new
> > mount option (data=guarded) to enable it.
>
> Is there a good reason to require a new mount option for this vs just
> calling it a fix (or enhancement) to the existing writeback option?
>
> I presume yes (you are fs guy..), but wonder what that reason is.
It is mostly cutting down on the risk of the patch. The patch tries to
isolate its changes to just data=guarded mode, so you can go back to the
old and crusty modes if things go badly.
-chris
next prev parent reply other threads:[~2009-04-28 18:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-28 18:04 [PATCH RFC] ext3 data=guarded v5 Chris Mason
2009-04-28 18:33 ` Mike Galbraith
2009-04-28 18:54 ` Chris Mason [this message]
2009-04-29 2:12 ` KOSAKI Motohiro
2009-04-29 8:56 ` Jan Kara
2009-04-29 14:08 ` Chris Mason
2009-04-29 14:43 ` Chris Mason
2009-04-29 19:47 ` Andreas Dilger
2009-04-29 19:15 ` Jan Kara
2009-04-29 19:41 ` Chris Mason
2009-04-29 20:04 ` Jan Kara
2009-04-29 20:37 ` Chris Mason
2009-04-30 11:38 ` Jan Kara
2009-04-29 21:53 ` Theodore Tso
2009-04-29 19:51 ` [PATCH RFC] ext3 data=guarded v6 Chris Mason
2009-04-29 20:21 ` Jan Kara
2009-04-29 20:53 ` [PATCH RFC] ext3 data=guarded v7 Chris Mason
2009-04-30 11:52 ` Jan Kara
2009-04-30 13:17 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240944854.15136.46.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=efault@gmx.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).