linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: stable@kernel.org
Cc: linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH,STABLE 2.6.29 07/18] ext4: Automatically allocate delay allocated blocks on rename
Date: Tue,  2 Jun 2009 08:07:48 -0400	[thread overview]
Message-ID: <1243944479-20574-7-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1243944479-20574-6-git-send-email-tytso@mit.edu>

When renaming a file such that a link to another inode is overwritten,
force any delay allocated blocks that to be allocated so that if the
filesystem is mounted with data=ordered, the data blocks will be
pushed out to disk along with the journal commit.  Many application
programs expect this, so we do this to avoid zero length files if the
system crashes unexpectedly.

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
(cherry picked from commit 8750c6d5fcbd3342b3d908d157f81d345c5325a7)
---
 fs/ext4/namei.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index f787234..63568ec 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2319,7 +2319,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,
 	struct inode *old_inode, *new_inode;
 	struct buffer_head *old_bh, *new_bh, *dir_bh;
 	struct ext4_dir_entry_2 *old_de, *new_de;
-	int retval;
+	int retval, force_da_alloc = 0;
 
 	old_bh = new_bh = dir_bh = NULL;
 
@@ -2457,6 +2457,7 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,
 		ext4_mark_inode_dirty(handle, new_inode);
 		if (!new_inode->i_nlink)
 			ext4_orphan_add(handle, new_inode);
+		force_da_alloc = 1;
 	}
 	retval = 0;
 
@@ -2465,6 +2466,8 @@ end_rename:
 	brelse(old_bh);
 	brelse(new_bh);
 	ext4_journal_stop(handle);
+	if (retval == 0 && force_da_alloc)
+		ext4_alloc_da_blocks(old_inode);
 	return retval;
 }
 
-- 
1.6.3.1.1.g75fc.dirty


  reply	other threads:[~2009-06-02 12:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-02 12:07 [PATCH,STABLE 2.6.29 01/18] ext4: don't inherit inappropriate inode flags from parent Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 02/18] ext4: tighten restrictions on inode flags Theodore Ts'o
2009-06-02 12:07   ` [PATCH,STABLE 2.6.29 03/18] ext4: return -EIO not -ESTALE on directory traversal through deleted inode Theodore Ts'o
2009-06-02 12:07     ` [PATCH,STABLE 2.6.29 04/18] ext4: Add fine print for the 32000 subdirectory limit Theodore Ts'o
2009-06-02 12:07       ` [PATCH,STABLE 2.6.29 05/18] ext4: add EXT4_IOC_ALLOC_DA_BLKS ioctl Theodore Ts'o
2009-06-02 12:07         ` [PATCH,STABLE 2.6.29 06/18] ext4: Automatically allocate delay allocated blocks on close Theodore Ts'o
2009-06-02 12:07           ` Theodore Ts'o [this message]
2009-06-02 12:07             ` [PATCH,STABLE 2.6.29 08/18] ext4: Fix discard of inode prealloc space with delayed allocation Theodore Ts'o
2009-06-02 12:07               ` [PATCH,STABLE 2.6.29 09/18] ext4: Add auto_da_alloc mount option Theodore Ts'o
2009-06-02 12:07                 ` [PATCH,STABLE 2.6.29 10/18] ext4: Check for an valid i_mode when reading the inode from disk Theodore Ts'o
2009-06-02 12:07                   ` [PATCH,STABLE 2.6.29 11/18] jbd2: Update locking coments Theodore Ts'o
2009-06-02 12:07                     ` [PATCH,STABLE 2.6.29 12/18] ext4: really print the find_group_flex fallback warning only once Theodore Ts'o
2009-06-02 12:07                       ` [PATCH,STABLE 2.6.29 13/18] ext4: Fix softlockup caused by illegal i_file_acl value in on-disk inode Theodore Ts'o
2009-06-02 12:07                         ` [PATCH,STABLE 2.6.29 14/18] ext4: Ignore i_file_acl_high unless EXT4_FEATURE_INCOMPAT_64BIT is present Theodore Ts'o
2009-06-02 12:07                           ` [PATCH,STABLE 2.6.29 15/18] ext4: Fix sub-block zeroing for writes into preallocated extents Theodore Ts'o
2009-06-02 12:07                             ` [PATCH,STABLE 2.6.29 16/18] ext4: Use a fake block number for delayed new buffer_head Theodore Ts'o
2009-06-02 12:07                               ` [PATCH,STABLE 2.6.29 17/18] ext4: Clear the unwritten buffer_head flag after the extent is initialized Theodore Ts'o
2009-06-02 12:07                                 ` [PATCH,STABLE 2.6.29 18/18] ext4: Fix race in ext4_inode_info.i_cached_extent Theodore Ts'o
2009-06-03 18:17                           ` [PATCH,STABLE 2.6.29 14/18] ext4: Ignore i_file_acl_high unless EXT4_FEATURE_INCOMPAT_64BIT is present Andreas Dilger
2009-06-03 18:16                         ` Fix softlockup caused by illegal i_file_acl value in on-disk inode Andreas Dilger
2009-06-03 19:24                           ` Theodore Tso
2009-06-03 18:14           ` [PATCH,STABLE 2.6.29 06/18] ext4: Automatically allocate delay allocated blocks on close Andreas Dilger
2009-06-03 19:29             ` Theodore Tso
2009-06-09  9:33     ` patch ext4-return-eio-not-estale-on-directory-traversal-through-deleted-inode.patch added to 2.6.29-stable tree gregkh
2009-06-09  9:33   ` patch ext4-tighten-restrictions-on-inode-flags.patch " gregkh
2009-06-09  9:33 ` patch ext4-don-t-inherit-inappropriate-inode-flags-from-parent.patch " gregkh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1243944479-20574-7-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).