From: Theodore Ts'o <tytso@mit.edu>
To: stable@kernel.org
Cc: linux-ext4@vger.kernel.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
"Theodore Ts'o" <tytso@mit.edu>
Subject: [PATCH,STABLE 2.6.29 08/18] ext4: Fix discard of inode prealloc space with delayed allocation.
Date: Tue, 2 Jun 2009 08:07:49 -0400 [thread overview]
Message-ID: <1243944479-20574-8-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1243944479-20574-7-git-send-email-tytso@mit.edu>
From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
With delayed allocation we should not/cannot discard inode prealloc
space during file close. We would still have dirty pages for which we
haven't allocated blocks yet. With this fix after each get_blocks
request we check whether we have zero reserved blocks and if yes and
we don't have any writers on the file we discard inode prealloc space.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
(cherry picked from commit d6014301b5599fba395c42a1e96a7fe86f7d0b2d)
---
fs/ext4/file.c | 3 ++-
fs/ext4/inode.c | 9 ++++++++-
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 06df827..588af8c 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -39,7 +39,8 @@ static int ext4_release_file(struct inode *inode, struct file *filp)
}
/* if we are the last writer on the inode, drop the block reservation */
if ((filp->f_mode & FMODE_WRITE) &&
- (atomic_read(&inode->i_writecount) == 1))
+ (atomic_read(&inode->i_writecount) == 1) &&
+ !EXT4_I(inode)->i_reserved_data_blocks)
{
down_write(&EXT4_I(inode)->i_data_sem);
ext4_discard_preallocations(inode);
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 8c7259a..3dafa6b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -1036,8 +1036,15 @@ static void ext4_da_update_reserve_space(struct inode *inode, int used)
/* update per-inode reservations */
BUG_ON(used > EXT4_I(inode)->i_reserved_data_blocks);
EXT4_I(inode)->i_reserved_data_blocks -= used;
next prev parent reply other threads:[~2009-06-02 12:08 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 12:07 [PATCH,STABLE 2.6.29 01/18] ext4: don't inherit inappropriate inode flags from parent Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 02/18] ext4: tighten restrictions on inode flags Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 03/18] ext4: return -EIO not -ESTALE on directory traversal through deleted inode Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 04/18] ext4: Add fine print for the 32000 subdirectory limit Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 05/18] ext4: add EXT4_IOC_ALLOC_DA_BLKS ioctl Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 06/18] ext4: Automatically allocate delay allocated blocks on close Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 07/18] ext4: Automatically allocate delay allocated blocks on rename Theodore Ts'o
2009-06-02 12:07 ` Theodore Ts'o [this message]
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 09/18] ext4: Add auto_da_alloc mount option Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 10/18] ext4: Check for an valid i_mode when reading the inode from disk Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 11/18] jbd2: Update locking coments Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 12/18] ext4: really print the find_group_flex fallback warning only once Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 13/18] ext4: Fix softlockup caused by illegal i_file_acl value in on-disk inode Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 14/18] ext4: Ignore i_file_acl_high unless EXT4_FEATURE_INCOMPAT_64BIT is present Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 15/18] ext4: Fix sub-block zeroing for writes into preallocated extents Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 16/18] ext4: Use a fake block number for delayed new buffer_head Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 17/18] ext4: Clear the unwritten buffer_head flag after the extent is initialized Theodore Ts'o
2009-06-02 12:07 ` [PATCH,STABLE 2.6.29 18/18] ext4: Fix race in ext4_inode_info.i_cached_extent Theodore Ts'o
2009-06-03 18:17 ` [PATCH,STABLE 2.6.29 14/18] ext4: Ignore i_file_acl_high unless EXT4_FEATURE_INCOMPAT_64BIT is present Andreas Dilger
2009-06-03 18:16 ` Fix softlockup caused by illegal i_file_acl value in on-disk inode Andreas Dilger
2009-06-03 19:24 ` Theodore Tso
2009-06-03 18:14 ` [PATCH,STABLE 2.6.29 06/18] ext4: Automatically allocate delay allocated blocks on close Andreas Dilger
2009-06-03 19:29 ` Theodore Tso
2009-06-09 9:33 ` patch ext4-return-eio-not-estale-on-directory-traversal-through-deleted-inode.patch added to 2.6.29-stable tree gregkh
2009-06-09 9:33 ` patch ext4-tighten-restrictions-on-inode-flags.patch " gregkh
2009-06-09 9:33 ` patch ext4-don-t-inherit-inappropriate-inode-flags-from-parent.patch " gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1243944479-20574-8-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).