From: Peng Tao <bergwolf@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: Theodore Tso <tytso@mit.edu>,
Akira Fujita <a-fujita@rs.jp.nec.com>,
Peng Tao <bergwolf@gmail.com>
Subject: [PATCH] e4defrag: fallocate donor file only once
Date: Wed, 2 Sep 2009 23:35:04 +0800 [thread overview]
Message-ID: <1251905704-10078-1-git-send-email-bergwolf@gmail.com> (raw)
If we allocate the donor file once for all, it will have a better chance
to be continuous.
Signed-off-by: "Peng Tao" <bergwolf@gmail.com>
---
misc/e4defrag.c | 21 ++++++++++-----------
1 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/misc/e4defrag.c b/misc/e4defrag.c
index c25514a..c1e9213 100644
--- a/misc/e4defrag.c
+++ b/misc/e4defrag.c
@@ -1603,6 +1603,7 @@ static int file_defrag(const char *file, const struct stat64 *buf,
struct fiemap_extent_list *donor_list_logical = NULL;
struct fiemap_extent_group *orig_group_head = NULL;
struct fiemap_extent_group *orig_group_tmp = NULL;
+ ext4_fsblk_t orig_block_count;
defraged_file_count++;
@@ -1742,19 +1743,17 @@ static int file_defrag(const char *file, const struct stat64 *buf,
/* Allocate space for donor inode */
orig_group_tmp = orig_group_head;
do {
- ret = fallocate(donor_fd, 0,
- (loff_t)orig_group_tmp->start->data.logical * block_size,
- (loff_t)orig_group_tmp->len * block_size);
- if (ret < 0) {
- if (mode_flag & DETAIL) {
- PRINT_FILE_NAME(file);
- PRINT_ERR_MSG_WITH_ERRNO("Failed to fallocate");
- }
- goto out;
- }
next reply other threads:[~2009-09-02 15:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-02 15:35 Peng Tao [this message]
2009-09-02 22:09 ` [PATCH] e4defrag: fallocate donor file only once Greg Freemyer
2009-09-02 22:24 ` Andreas Dilger
2009-09-03 8:00 ` Peng Tao
2009-09-03 9:30 ` Greg Freemyer
2009-09-04 3:08 ` Peng Tao
2009-09-04 12:36 ` Greg Freemyer
2009-09-04 16:56 ` Peng Tao
2009-09-04 19:10 ` Greg Freemyer
2009-09-05 16:29 ` Peng Tao
2009-09-08 15:41 ` Greg Freemyer
2009-09-09 1:24 ` Peng Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251905704-10078-1-git-send-email-bergwolf@gmail.com \
--to=bergwolf@gmail.com \
--cc=a-fujita@rs.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).