From: Tobias Doerffel <tobias.doerffel@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: Tobias Doerffel <tobias.doerffel@gmail.com>
Subject: [PATCH] ext4: in ext4_dirty_inode() current_handle only needed for debugging
Date: Sat, 3 Oct 2009 00:20:48 +0200 [thread overview]
Message-ID: <1254522048-15046-1-git-send-email-tobias.doerffel@gmail.com> (raw)
As of d3d1faf6a74496ea4435fd057c6a2cad49f3e523 in ext4_dirty_inode()
the current_handle variable is only used for debugging now. Therefore
compiling fs/ext4/inode.c without JBD_DEBUG set will result in a
compiler warning:
fs/ext4/inode.c: In function ‘ext4_dirty_inode’:
fs/ext4/inode.c:5818: warning: unused variable ‘current_handle’
This commit fixes the issue by adding an according #ifdef directive.
---
fs/ext4/inode.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 26f1a0a..e5daa6c 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -5815,7 +5815,9 @@ int ext4_mark_inode_dirty(handle_t *handle, struct inode *inode)
*/
void ext4_dirty_inode(struct inode *inode)
{
+#ifdef CONFIG_JBD_DEBUG
handle_t *current_handle = ext4_journal_current_handle();
+#endif
handle_t *handle;
handle = ext4_journal_start(inode, 2);
--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2009-10-02 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 22:20 Tobias Doerffel [this message]
2009-10-02 22:36 ` [PATCH] ext4: in ext4_dirty_inode() current_handle only needed for debugging Tobias Doerffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254522048-15046-1-git-send-email-tobias.doerffel@gmail.com \
--to=tobias.doerffel@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).