linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH, RFC 1/3] ext4: Convert calls of ext4_error() to EXT4_ERROR_INODE()
Date: Thu, 18 Mar 2010 20:50:40 -0400	[thread overview]
Message-ID: <1268959842-4697-1-git-send-email-tytso@mit.edu> (raw)

EXT4_ERROR_INODE() tends to provide better error information and in a
more consistent format.

Addresses-Google-Bug: #2507977

Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---

Yes, there are more calls to ext4_error that we probably want to convert
to use ext4_error_inode; this is just for illustrative purposes, and
because it's the one which is most obnoxious if there is a bad entry in
a particular inode which is referenced over and over again (see patch 3
in this series).

 fs/ext4/namei.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 0c070fa..0c0cba4 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1072,9 +1072,9 @@ static struct dentry *ext4_lookup(struct inode *dir, struct dentry *dentry, stru
 		inode = ext4_iget(dir->i_sb, ino);
 		if (unlikely(IS_ERR(inode))) {
 			if (PTR_ERR(inode) == -ESTALE) {
-				ext4_error(dir->i_sb,
-						"deleted inode referenced: %u",
-						ino);
+				EXT4_ERROR_INODE(dir,
+						 "deleted inode referenced: %u",
+						 ino);
 				return ERR_PTR(-EIO);
 			} else {
 				return ERR_CAST(inode);
-- 
1.6.6.1.1.g974db.dirty


             reply	other threads:[~2010-03-19  0:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-19  0:50 Theodore Ts'o [this message]
2010-03-19  0:50 ` [PATCH, RFC 2/3] ext4: Add support for adding boolean toggls to ext4's sysfs directory Theodore Ts'o
2010-03-19  0:50 ` [PATCH, RFC 3/3] ext4: Add option for squelching ext4 errors to prevent dmesg from filling up Theodore Ts'o
2010-03-19 22:56   ` Andreas Dilger
2010-03-20  2:20     ` tytso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268959842-4697-1-git-send-email-tytso@mit.edu \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).