linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Blunck <jblunck@suse.de>
To: Jan Kara <jack@suse.cz>, tytso@mit.edu
Cc: Linux-Kernel Mailinglist <linux-kernel@vger.kernel.org>,
	linux-ext4@vger.kernel.org,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, Jan Blunck <jblunck@suse.de>
Subject: [PATCH 3/5] ext2: Remove duplicate code from ext2_sync_fs()
Date: Mon, 12 Apr 2010 22:41:43 +0200	[thread overview]
Message-ID: <1271104905-8804-4-git-send-email-jblunck@suse.de> (raw)
In-Reply-To: <1271104905-8804-1-git-send-email-jblunck@suse.de>

Depending in the state (valid or unchecked) of the filesystem either
ext2_sync_super() or ext2_commit_super() is called. If the filesystem is
currently valid (it is checked), we first mark it unchecked and afterwards
duplicate the work that ext2_sync_super() is doing later. Therefore this
patch removes the duplicate code and calls ext2_sync_super() directly after
marking the filesystem unchecked.

Signed-off-by: Jan Blunck <jblunck@suse.de>
---
 fs/ext2/super.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 4a17ca3..40fc8d5 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1164,16 +1164,9 @@ static int ext2_sync_fs(struct super_block *sb, int wait)
 	struct buffer_head *sbh = EXT2_SB(sb)->s_sbh;
 
 	lock_kernel();
-	ext2_clear_super_error(sb);

  parent reply	other threads:[~2010-04-12 20:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-12 20:41 [PATCH 0/5] ext2: Preparation to remove BKL Jan Blunck
2010-04-12 20:41 ` [PATCH 1/5] ext2: Use ext2_clear_super_error() in ext2_sync_fs() Jan Blunck
2010-04-12 20:41 ` [PATCH 2/5] ext2: Set the write time " Jan Blunck
2010-04-12 20:41 ` Jan Blunck [this message]
2010-04-12 20:41 ` [PATCH 4/5] ext2: Move ext2_write_super() out of ext2_setup_super() Jan Blunck
2010-04-13 17:53   ` Jan Kara
2010-04-14  7:55     ` Jan Blunck
2010-04-12 20:41 ` [PATCH 5/5] ext2: Add ext2_sb_info s_lock spinlock Jan Blunck
2010-04-13 19:09   ` Jan Kara
2010-04-14  8:19     ` Jan Blunck
2010-04-14  7:10   ` Jaswinder Singh Rajput
2010-04-14  8:00     ` Jan Blunck
2010-04-12 21:01 ` [PATCH 0/5] ext2: Preparation to remove BKL Frederic Weisbecker
2010-04-13  9:31   ` Arnd Bergmann
2010-04-13 20:12     ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1271104905-8804-4-git-send-email-jblunck@suse.de \
    --to=jblunck@suse.de \
    --cc=arnd@arndb.de \
    --cc=fweisbec@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).