From: Jeff Moyer <jmoyer@redhat.com>
To: jens.axboe@oracle.com
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
vgoyal@redhat.com, Jeff Moyer <jmoyer@redhat.com>
Subject: [PATCH 4/4] jbd2: yield the device queue when waiting for journal commits
Date: Wed, 14 Apr 2010 17:17:06 -0400 [thread overview]
Message-ID: <1271279826-30294-5-git-send-email-jmoyer@redhat.com> (raw)
In-Reply-To: <1271279826-30294-1-git-send-email-jmoyer@redhat.com>
This patch gets CFQ back in line with deadline for iozone runs, especially
those testing small files + fsync timings.
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
---
fs/jbd2/journal.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index c03d4dc..ce46df6 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -41,6 +41,7 @@
#include <linux/hash.h>
#include <linux/log2.h>
#include <linux/vmalloc.h>
+#include <linux/blkdev.h>
#define CREATE_TRACE_POINTS
#include <trace/events/jbd2.h>
@@ -580,6 +581,11 @@ int jbd2_log_wait_commit(journal_t *journal, tid_t tid)
while (tid_gt(tid, journal->j_commit_sequence)) {
jbd_debug(1, "JBD: want %d, j_commit_sequence=%d\n",
tid, journal->j_commit_sequence);
+ /*
+ * Give up our I/O scheduler time slice to allow the journal
+ * thread to issue I/O.
+ */
+ blk_yield(journal->j_dev->bd_disk->queue);
wake_up(&journal->j_wait_commit);
spin_unlock(&journal->j_state_lock);
wait_event(journal->j_wait_done_commit,
--
1.6.2.5
next prev parent reply other threads:[~2010-04-14 21:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 21:17 [PATCH 0/4 v3] ext3/4: enhance fsync performance when using CFQ Jeff Moyer
2010-04-14 21:17 ` [PATCH 1/4] cfq-iosched: Keep track of average think time for the sync-noidle workload Jeff Moyer
2010-04-14 21:37 ` Vivek Goyal
2010-04-14 23:06 ` Jeff Moyer
2010-04-14 21:17 ` [PATCH 2/4] block: Implement a blk_yield function to voluntarily give up the I/O scheduler Jeff Moyer
2010-04-14 21:46 ` Vivek Goyal
2010-04-15 10:33 ` Jens Axboe
2010-04-15 15:49 ` Jeff Moyer
2010-04-14 21:17 ` [PATCH 3/4] jbd: yield the device queue when waiting for commits Jeff Moyer
2010-04-14 21:17 ` Jeff Moyer [this message]
2010-04-15 10:33 ` [PATCH 4/4] jbd2: yield the device queue when waiting for journal commits Jens Axboe
2010-04-15 10:33 ` [PATCH 0/4 v3] ext3/4: enhance fsync performance when using CFQ Jens Axboe
2010-04-15 13:05 ` Jeff Moyer
2010-04-15 13:08 ` Jens Axboe
2010-04-15 13:13 ` Jeff Moyer
2010-04-15 14:03 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2010-05-18 18:20 [PATCH 0/4 v4] " Jeff Moyer
2010-05-18 18:20 ` [PATCH 4/4] jbd2: yield the device queue when waiting for journal commits Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1271279826-30294-5-git-send-email-jmoyer@redhat.com \
--to=jmoyer@redhat.com \
--cc=jens.axboe@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).