From: Ben Hutchings <ben@decadent.org.uk>
To: Theodore Ts'o <tytso@mit.edu>, Andreas Dilger <adilger@sun.com>
Cc: linux-ext4@vger.kernel.org
Subject: [PATCH 1/2] ext4: Conditionally define compat ioctl numbers
Date: Fri, 21 May 2010 00:30:22 +0100 [thread overview]
Message-ID: <1274398223.2257.0.camel@localhost> (raw)
It is unnecessary, and in general impossible, to define the compat
ioctl numbers except when building the filesystem with CONFIG_COMPAT
defined.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
fs/ext4/ext4.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index bf938cf..f5c9941 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -398,6 +398,7 @@ struct ext4_new_group_data {
#define EXT4_IOC_ALLOC_DA_BLKS _IO('f', 12)
#define EXT4_IOC_MOVE_EXT _IOWR('f', 15, struct move_extent)
+#if defined(__KERNEL__) && defined(CONFIG_COMPAT)
/*
* ioctl commands in 32 bit emulation
*/
@@ -413,6 +414,7 @@ struct ext4_new_group_data {
#endif
#define EXT4_IOC32_GETVERSION_OLD FS_IOC32_GETVERSION
#define EXT4_IOC32_SETVERSION_OLD FS_IOC32_SETVERSION
+#endif
/*
--
1.7.1
next reply other threads:[~2010-05-20 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 23:30 Ben Hutchings [this message]
2010-05-20 23:34 ` [PATCH 2/2] ext4: Fix compat EXT4_IOC_ADD_GROUP Ben Hutchings
2010-05-21 4:41 ` Andreas Dilger
2010-05-25 15:08 ` tytso
2010-05-25 15:25 ` tytso
2010-05-25 15:15 ` [PATCH 1/2] ext4: Conditionally define compat ioctl numbers tytso
2010-05-25 15:22 ` tytso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1274398223.2257.0.camel@localhost \
--to=ben@decadent.org.uk \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).