From: Jeff Moyer <jmoyer@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, vgoyal@redhat.com,
tao.ma@oracle.com, Jeff Moyer <jmoyer@redhat.com>
Subject: [PATCH 4/6] jbd: use WRITE_SYNC for journal I/O
Date: Fri, 2 Jul 2010 15:58:17 -0400 [thread overview]
Message-ID: <1278100699-24132-5-git-send-email-jmoyer@redhat.com> (raw)
In-Reply-To: <1278100699-24132-1-git-send-email-jmoyer@redhat.com>
In my fsync testing, journal I/O most definitely was sync I/O, since
another process was blocked waiting for the results. By marking all
journal I/O as WRITE_SYNC, I can get better performance with CFQ.
If there is a way to mark this only for cases where it is blocking progress
in a dependent process, then that would be preferrable. Is there such a
means for determining and flagging this?
Cheers,
Jeff
Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
---
fs/jbd/commit.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c
index 28a9dda..d97a0c6 100644
--- a/fs/jbd/commit.c
+++ b/fs/jbd/commit.c
@@ -317,7 +317,7 @@ void journal_commit_transaction(journal_t *journal)
int first_tag = 0;
int tag_flag;
int i;
- int write_op = WRITE;
+ int write_op = WRITE_SYNC;
/*
* First job: lock down the current transaction and wait for
--
1.6.5.2
next prev parent reply other threads:[~2010-07-02 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-02 19:58 [PATCH 0/6 v6][RFC] jbd[2]: enhance fsync performance when using CFQ Jeff Moyer
2010-07-02 19:58 ` [PATCH 1/6] block: Implement a blk_yield function to voluntarily give up the I/O scheduler Jeff Moyer
2010-07-02 19:58 ` [PATCH 2/6] jbd: yield the device queue when waiting for commits Jeff Moyer
2010-07-02 19:58 ` [PATCH 3/6] jbd2: yield the device queue when waiting for journal commits Jeff Moyer
2010-07-02 19:58 ` Jeff Moyer [this message]
2010-07-02 19:58 ` [PATCH 5/6] jbd2: use WRITE_SYNC for journal I/O Jeff Moyer
2010-07-02 19:58 ` [PATCH 6/6] block: remove RQ_NOIDLE from WRITE_SYNC Jeff Moyer
2010-07-02 20:23 ` [PATCH 0/6 v6][RFC] jbd[2]: enhance fsync performance when using CFQ Vivek Goyal
2010-07-02 20:32 ` Jeff Moyer
2010-07-06 6:27 ` Tao Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278100699-24132-5-git-send-email-jmoyer@redhat.com \
--to=jmoyer@redhat.com \
--cc=axboe@kernel.dk \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tao.ma@oracle.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).