linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Moyer <jmoyer@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org, vgoyal@redhat.com,
	tao.ma@oracle.com, Jeff Moyer <jmoyer@redhat.com>
Subject: [PATCH 6/6] block: remove RQ_NOIDLE from WRITE_SYNC
Date: Fri,  2 Jul 2010 15:58:19 -0400	[thread overview]
Message-ID: <1278100699-24132-7-git-send-email-jmoyer@redhat.com> (raw)
In-Reply-To: <1278100699-24132-1-git-send-email-jmoyer@redhat.com>

In trying to get fsync-ing processes to perform as well under CFQ as they
do in deadline, I found (with the current blk_yield approach) that it was
necessary to get rid of the RQ_NOIDLE flag for WRITE_SYNC I/O.  Instead,
we do explicit yielding of the I/O scheduler.

Comments, as always, are greatly appreciated.

Cheers,
Jeff

Signed-off-by: Jeff Moyer <jmoyer@redhat.com>
---
 include/linux/fs.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/fs.h b/include/linux/fs.h
index 471e1ff..da34297 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -152,12 +152,12 @@ struct inodes_stat_t {
 #define SWRITE 3	/* for ll_rw_block() - wait for buffer lock */
 #define READ_SYNC	(READ | (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_UNPLUG))
 #define READ_META	(READ | (1 << BIO_RW_META))
-#define WRITE_SYNC_PLUG	(WRITE | (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_NOIDLE))
+#define WRITE_SYNC_PLUG	(WRITE | (1 << BIO_RW_SYNCIO))
 #define WRITE_SYNC	(WRITE_SYNC_PLUG | (1 << BIO_RW_UNPLUG))
 #define WRITE_ODIRECT_PLUG	(WRITE | (1 << BIO_RW_SYNCIO))
 #define WRITE_META	(WRITE | (1 << BIO_RW_META))
 #define SWRITE_SYNC_PLUG	\
-			(SWRITE | (1 << BIO_RW_SYNCIO) | (1 << BIO_RW_NOIDLE))
+			(SWRITE | (1 << BIO_RW_SYNCIO))
 #define SWRITE_SYNC	(SWRITE_SYNC_PLUG | (1 << BIO_RW_UNPLUG))
 #define WRITE_BARRIER	(WRITE | (1 << BIO_RW_BARRIER))
 
-- 
1.6.5.2


  parent reply	other threads:[~2010-07-02 19:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-02 19:58 [PATCH 0/6 v6][RFC] jbd[2]: enhance fsync performance when using CFQ Jeff Moyer
2010-07-02 19:58 ` [PATCH 1/6] block: Implement a blk_yield function to voluntarily give up the I/O scheduler Jeff Moyer
2010-07-02 19:58 ` [PATCH 2/6] jbd: yield the device queue when waiting for commits Jeff Moyer
2010-07-02 19:58 ` [PATCH 3/6] jbd2: yield the device queue when waiting for journal commits Jeff Moyer
2010-07-02 19:58 ` [PATCH 4/6] jbd: use WRITE_SYNC for journal I/O Jeff Moyer
2010-07-02 19:58 ` [PATCH 5/6] jbd2: " Jeff Moyer
2010-07-02 19:58 ` Jeff Moyer [this message]
2010-07-02 20:23 ` [PATCH 0/6 v6][RFC] jbd[2]: enhance fsync performance when using CFQ Vivek Goyal
2010-07-02 20:32   ` Jeff Moyer
2010-07-06  6:27 ` Tao Ma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278100699-24132-7-git-send-email-jmoyer@redhat.com \
    --to=jmoyer@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tao.ma@oracle.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).