From: Calvin Walton <calvin.walton@gmail.com>
To: Florian Weimer <fweimer@bfk.de>
Cc: miaox@cn.fujitsu.com, Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Chris Mason <chris.mason@oracle.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
Linux Ext4 <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 2/3] lib: improve the performance of memcpy and memmove of the general version
Date: Sat, 04 Sep 2010 08:59:02 -0400 [thread overview]
Message-ID: <1283605142.9039.4.camel@ayu> (raw)
In-Reply-To: <82mxrzrsvq.fsf@mid.bfk.de>
On Fri, 2010-09-03 at 11:03 +0000, Florian Weimer wrote:
> * Miao Xie:
>
> > EXPORT_SYMBOL(memcpy);
>
> I think you need to change that to EXPORT_SYMBOL_GPL, because the code
> is now licensed under the GPL, and not the GPL plus kernel exceptions
> (whatever they are, but they undoubtly exist), unlike the original
> implementation.
I wouldn't think so - the intent of EXPORT_SYMBOL_GPL is to mark symbols
that make it obvious that a module was derived from the Linux kernel, as
opposed to some sort of generic driver that was just ported to a new
interface. (It's not foolproof, it's more of a warning to developers.)
If you think of it this way, memcpy is a function defined in the C
standard, there's absolutely nothing Linux-specific about using it.
Of course, IANAL; and you should probably grab some more opinions on the
matter.
--
Calvin Walton <calvin.walton@gmail.com>
next prev parent reply other threads:[~2010-09-04 12:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 10:36 [PATCH 2/3] lib: improve the performance of memcpy and memmove of the general version Miao Xie
2010-09-03 11:03 ` Florian Weimer
2010-09-03 18:16 ` Andreas Dilger
2010-09-04 12:59 ` Calvin Walton [this message]
2010-09-04 14:41 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2010-09-02 5:46 Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283605142.9039.4.camel@ayu \
--to=calvin.walton@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=chris.mason@oracle.com \
--cc=fweimer@bfk.de \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).