From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Czerner Subject: [PATCH] block: Make blkdev_issue_discard() interruptible Date: Thu, 21 Oct 2010 17:54:46 +0200 Message-ID: <1287676486-19645-1-git-send-email-lczerner@redhat.com> References: <1287671673-11448-1-git-send-email-lczerner@redhat.com> Cc: tytso@mit.edu, sandeen@redhat.com, adilger@dilger.ca, axboe@kernel.dk, linux-kernel@vger.kernel.org, lczerner@redhat.com To: linux-ext4@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:14612 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915Ab0JUPy4 (ORCPT ); Thu, 21 Oct 2010 11:54:56 -0400 In-Reply-To: <1287671673-11448-1-git-send-email-lczerner@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Since the discard may take quite long time, especially with really big extents (like the whole device for example), it would be nice to give to users the opportunity to abort it. This is especially useful for mkfs, when user can not know in advance how long it will take. In conjunction with mke2fs patch "Inform user about ongoing discard" it gives the user all the comfort of being informed about discard and being able to abort the operation. Signed-off-by: Lukas Czerner --- block/blk-lib.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/block/blk-lib.c b/block/blk-lib.c index 1a320d2..db44671 100644 --- a/block/blk-lib.c +++ b/block/blk-lib.c @@ -91,6 +91,9 @@ int blkdev_issue_discard(struct block_device *bdev, sector_t sector, bio_get(bio); submit_bio(type, bio); + if (unlikely(fatal_signal_pending(current))) + ret = -ERESTARTSYS; + wait_for_completion(&wait); if (bio_flagged(bio, BIO_EOPNOTSUPP)) -- 1.7.2.3