From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: jmoyer@redhat.com, tytso@mit.edu, sandeen@redhat.com,
adilger@dilger.ca, axboe@kernel.dk, linux-kernel@vger.kernel.org,
lczerner@redhat.com
Subject: [PATCH] block: Make blkdev_issue_discard() interruptible
Date: Fri, 22 Oct 2010 13:06:09 +0200 [thread overview]
Message-ID: <1287745569-11705-1-git-send-email-lczerner@redhat.com> (raw)
In-Reply-To: <x49k4lb1oah.fsf@segfault.boston.devel.redhat.com>
Since the discard may take quite long time, especially with really big
extents (like the whole device for example), it would be nice to give to
users the opportunity to abort it. This is especially useful for mkfs,
when user can not know in advance how long it will take.
In conjunction with mke2fs patch "Inform user about ongoing discard"
it gives the user all the comfort of being informed about discard and
being able to abort the operation.
It has been tested on SSD device where mkfs.ext4 without -K takes rally
long due to discarding whole device. With this patch I am able to
successfully terminate that with ctrl+c. Aside that discard functionality
remains unchanged.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
block/blk-lib.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/block/blk-lib.c b/block/blk-lib.c
index c392029..54994e7 100644
--- a/block/blk-lib.c
+++ b/block/blk-lib.c
@@ -101,6 +101,9 @@ int blkdev_issue_discard(struct block_device *bdev, sector_t sector,
else if (!bio_flagged(bio, BIO_UPTODATE))
ret = -EIO;
bio_put(bio);
+
+ if (unlikely(fatal_signal_pending(current)))
+ ret = -ERESTARTSYS;
}
return ret;
--
1.7.2.3
next prev parent reply other threads:[~2010-10-22 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 14:34 [PATCH] block: Make blkdev_issue_discard() interruptible Lukas Czerner
2010-10-21 15:54 ` Lukas Czerner
2010-10-21 16:52 ` Jeff Moyer
2010-10-22 11:06 ` Lukas Czerner [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-09-15 14:32 Lukas Czerner
2010-09-15 14:59 ` Mike Snitzer
2010-09-15 16:16 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287745569-11705-1-git-send-email-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=adilger@dilger.ca \
--cc=axboe@kernel.dk \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).