* [PATCH] ext4: Fix lazyinit hang after removing request
@ 2010-10-29 13:20 Lukas Czerner
2010-11-02 18:20 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Lukas Czerner @ 2010-10-29 13:20 UTC (permalink / raw)
To: tytso; +Cc: linux-kernel, linux-ext4, sandeen, adilger, lczerner
When the request has been removed from the list and no other request
has been issued, we will end up with next wakeup scheduled to
MAX_JIFFY_OFFSET which is bad. So check for that.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
fs/ext4/super.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 0348ce0..29c3078 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -2740,7 +2740,8 @@ cont_thread:
if (freezing(current))
refrigerator();
- if (time_after_eq(jiffies, next_wakeup)) {
+ if ((time_after_eq(jiffies, next_wakeup)) ||
+ (MAX_JIFFY_OFFSET == next_wakeup)) {
cond_resched();
continue;
}
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: Fix lazyinit hang after removing request
2010-10-29 13:20 [PATCH] ext4: Fix lazyinit hang after removing request Lukas Czerner
@ 2010-11-02 18:20 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2010-11-02 18:20 UTC (permalink / raw)
To: Lukas Czerner; +Cc: linux-kernel, linux-ext4, sandeen, adilger
On Fri, Oct 29, 2010 at 03:20:20PM +0200, Lukas Czerner wrote:
> When the request has been removed from the list and no other request
> has been issued, we will end up with next wakeup scheduled to
> MAX_JIFFY_OFFSET which is bad. So check for that.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Queued for pushing to Linus for 2.6.27-rc2, thanks.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-02 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-29 13:20 [PATCH] ext4: Fix lazyinit hang after removing request Lukas Czerner
2010-11-02 18:20 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).