From: Namhyung Kim <namhyung@gmail.com>
To: Jan Kara <jack@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ext3: Add journal error check into ext3_rename()
Date: Tue, 23 Nov 2010 12:37:10 +0900 [thread overview]
Message-ID: <1290483430.1857.43.camel@leonhard> (raw)
In-Reply-To: <20101122180501.GE5012@quack.suse.cz>
2010-11-22 (월), 19:05 +0100, Jan Kara:
> Uhuh, why ext3_journal_revoke()? I expect you want to cancel the changes
> you possibly did to new_bh. ext3_journal_forget() is for that but even that
> doesn't necessarily do what you want because it could cancel also changes
> some unrelated operation did to the buffer. So the only way to really undo
> the change is to set new_de->inode and new_de->file_type to original
> values. Also since we already unlinked the inode from the old directory,
> I'm not sure it's even beneficial to undo linking it to the new one. So I'd
> just bail out as fast as we can and leave on fsck to handle the mess...
>
> Honza
Right. I wanted cancel the changes but I wasn't sure what I did. Thanks
for the explanation. I'll send v2 soon.
--
Regards,
Namhyung Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-11-23 3:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 7:28 [PATCH 1/2] ext3: Add journal error check into ext3_delete_entry() Namhyung Kim
2010-11-19 7:28 ` [PATCH 2/2] ext3: Add journal error check into ext3_rename() Namhyung Kim
2010-11-22 18:05 ` Jan Kara
2010-11-23 3:37 ` Namhyung Kim [this message]
2010-11-22 17:55 ` [PATCH 1/2] ext3: Add journal error check into ext3_delete_entry() Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290483430.1857.43.camel@leonhard \
--to=namhyung@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).