From: yangsheng <sickamd@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: adilger@dilger.ca, linux-fsdevel@vger.kernel.org,
linux-ext4@vger.kernel.org, swhiteho@redhat.com,
yangsheng <sickamd@gmail.com>,
sickadm@gmail.com
Subject: [PATCH resend] Update atime from future.
Date: Tue, 4 Jan 2011 16:56:58 +0800 [thread overview]
Message-ID: <1294131418-3835-1-git-send-email-sickamd@gmail.com> (raw)
If atime has been wrong set to future, then it cannot
be updated back to current time.
CC: swhiteho@redhat.com
Signed-off-by: sickadm@gmail.com
Reviewed-by: adilger@dilger.ca
---
fs/inode.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/fs/inode.c b/fs/inode.c
index da85e56..9cf7375 100644
--- a/fs/inode.c
+++ b/fs/inode.c
@@ -1446,6 +1446,8 @@ sector_t bmap(struct inode *inode, sector_t block)
}
EXPORT_SYMBOL(bmap);
+#define RELATIME_MARGIN (24 * 60 * 60)
+
/*
* With relative atime, only update atime if the previous atime is
* earlier than either the ctime or mtime or if at least a day has
@@ -1469,10 +1471,16 @@ static int relatime_need_update(struct vfsmount *mnt, struct inode *inode,
return 1;
/*
- * Is the previous atime value older than a day? If yes,
+ * Is the previous atime value in future? If yes,
+ * update atime:
+ */
+ if ((long)(now.tv_sec - inode->i_atime.tv_sec) < -RELATIME_MARGIN)
+ return 1;
+ /*
+ * Is the previous atime value old than a day? If yes,
* update atime:
*/
- if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= 24*60*60)
+ if ((long)(now.tv_sec - inode->i_atime.tv_sec) >= RELATIME_MARGIN)
return 1;
/*
* Good, we can skip the atime update:
--
1.7.2.3
next reply other threads:[~2011-01-04 8:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-04 8:56 yangsheng [this message]
2011-01-04 9:02 ` [PATCH resend] Update atime from future Andreas Schwab
2011-01-04 9:05 ` YangSheng
2011-01-04 18:21 ` Valdis.Kletnieks
2011-01-04 19:13 ` Andreas Dilger
2011-01-04 20:31 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294131418-3835-1-git-send-email-sickamd@gmail.com \
--to=sickamd@gmail.com \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sickadm@gmail.com \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).