From: Mingming Cao <cmm@us.ibm.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: "Ted Ts'o" <tytso@mit.edu>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V3 RESEND 2] ext4: serialize unaligned asynchronous DIO
Date: Mon, 07 Feb 2011 14:18:22 -0800 [thread overview]
Message-ID: <1297117102.3207.311.camel@mingming-laptop> (raw)
In-Reply-To: <4D5032BD.4030708@redhat.com>
On Mon, 2011-02-07 at 11:58 -0600, Eric Sandeen wrote:
> On 02/07/2011 09:59 AM, Ted Ts'o wrote:
> > On Sun, Feb 06, 2011 at 09:33:36PM -0500, Ted Ts'o wrote:
> >>
> >> Hey Eric,
> >>
> >> One question about this patch. You are currently using a hashed array
> >> of size 37 for the waitqueue; what about using a similarly sized
> >> hashed array for the aio_mutex? We only take it for unaligned
> >> mutexes, and I'm trying to work on reducing the size of ext4 inode,
> >> since it gets rather large in the inode cache....
> >>
> >> - Ted
> >
> > Like this.... I also changed to_ioend_wq() and ioend_wq[] to be
> > ext4_ioend_wq() and ext4__ioend_wq[], since they are now global
> > variables.
> >
>
> Looks fine to me, thanks, feel free to put an akpm-style comment
> in the commit about what you fixed up.
>
> -Eric
Ted, Eric,
If it matters, you could add reviewed-by: Mingming Cao <cmm@us.ibm.com>
from me. The modified version looks fine with me.
Mingming
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-07 22:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 22:23 [PATCH] ext4: serialize unaligned asynchronous DIO Eric Sandeen
2011-01-14 4:15 ` Ted Ts'o
2011-01-14 4:41 ` Eric Sandeen
2011-01-14 17:28 ` [PATCH V2] " Eric Sandeen
2011-01-18 16:23 ` Eric Sandeen
2011-01-21 16:00 ` Eric Sandeen
2011-01-21 18:26 ` [PATCH V3 RESEND 2] " Eric Sandeen
2011-01-21 23:27 ` Ted Ts'o
2011-02-07 2:33 ` Ted Ts'o
2011-02-07 15:59 ` Ted Ts'o
2011-02-07 17:58 ` Eric Sandeen
2011-02-07 22:18 ` Mingming Cao [this message]
2012-02-23 13:23 ` backport "ext4: serialize unaligned asynchronous DIO" to 2.6.32 Philipp Hahn
2012-02-23 15:15 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297117102.3207.311.camel@mingming-laptop \
--to=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox