From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, Lukas Czerner <lczerner@redhat.com>
Subject: [PATCH] e2fsprogs: remove leftover retval check
Date: Tue, 15 Mar 2011 12:58:38 +0100 [thread overview]
Message-ID: <1300190318-23164-1-git-send-email-lczerner@redhat.com> (raw)
Remove leftover retval check from the read_bitmaps(). It is not
necessary as it is not previously set by any function, moreover the
retval value is not initialized in definition which may cause errors
when garbage data appears in it.
Also initialize retval to zero in definition.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
lib/ext2fs/rw_bitmaps.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/lib/ext2fs/rw_bitmaps.c b/lib/ext2fs/rw_bitmaps.c
index d6f35fd..086d4b7 100644
--- a/lib/ext2fs/rw_bitmaps.c
+++ b/lib/ext2fs/rw_bitmaps.c
@@ -33,7 +33,7 @@ static errcode_t write_bitmaps(ext2_filsys fs, int do_inode, int do_block)
unsigned int j;
int block_nbytes, inode_nbytes;
unsigned int nbits;
- errcode_t retval;
+ errcode_t retval = 0;
char *block_buf, *inode_buf;
int csum_flag = 0;
blk64_t blk;
@@ -159,8 +159,6 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block)
EXT4_FEATURE_RO_COMPAT_GDT_CSUM))
csum_flag = 1;
- if (retval)
- return retval;
if (do_block) {
if (fs->block_map)
ext2fs_free_block_bitmap(fs->block_map);
--
1.7.4
next reply other threads:[~2011-03-15 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 11:58 Lukas Czerner [this message]
2011-03-15 12:02 ` [PATCH] e2fsprogs: remove leftover retval check Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300190318-23164-1-git-send-email-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox