From: Robin Dong <hao.bigrat@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: Robin Dong <sanbai@taobao.com>, stable@kernel.org
Subject: [PATCH] ext4: critical info format fix in __ext4_grp_locked_error
Date: Thu, 17 Mar 2011 09:56:31 +0800 [thread overview]
Message-ID: <1300326991-22794-1-git-send-email-hao.bigrat@gmail.com> (raw)
From: Robin Dong <sanbai@taobao.com>
When we do performence-testing on ext4 filesystem, we observe a warning like this:
"[ 1684.113205] EXT4-fs error (device sda7): ext4_mb_generate_buddy:718: group 259825901 blocks in bitmap, 26057 in gd"
indeed, it should be
"group 2598, 25901 blocks in bitmap, 26057 in gd"
Reviewed-by: Coly Li <bosong.ly@taobao.com>
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/super.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index f6a318f..bb38475 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -594,7 +594,7 @@ __acquires(bitlock)
vaf.fmt = fmt;
vaf.va = &args;
- printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u",
+ printk(KERN_CRIT "EXT4-fs error (device %s): %s:%d: group %u, ",
sb->s_id, function, line, grp);
if (ino)
printk(KERN_CONT "inode %lu: ", ino);
--
1.7.3.5
next reply other threads:[~2011-03-17 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 1:56 Robin Dong [this message]
2011-03-17 2:08 ` [stable] [PATCH] ext4: critical info format fix in __ext4_grp_locked_error Greg KH
-- strict thread matches above, loose matches on Subject: below --
2011-03-18 9:58 Robin Dong
2011-03-22 0:47 ` Ted Ts'o
2011-03-22 2:30 ` Tao Ma
2011-03-22 5:35 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300326991-22794-1-git-send-email-hao.bigrat@gmail.com \
--to=hao.bigrat@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sanbai@taobao.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).