From: Shaohua Li <shaohua.li@intel.com>
To: linux-ext4@vger.kernel.org
Cc: Ted Ts'o <tytso@mit.edu>, Tejun Heo <tj@kernel.org>
Subject: [PATCH]ext4: delete dead code
Date: Thu, 14 Apr 2011 10:10:32 +0800 [thread overview]
Message-ID: <1302747032.3981.181.camel@sli10-conroe> (raw)
percpu_counter_sum_positive never returns negative.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
---
fs/ext4/balloc.c | 5 -----
1 file changed, 5 deletions(-)
Index: linux/fs/ext4/balloc.c
===================================================================
--- linux.orig/fs/ext4/balloc.c 2011-04-12 16:22:59.000000000 +0800
+++ linux/fs/ext4/balloc.c 2011-04-13 13:23:01.000000000 +0800
@@ -507,11 +507,6 @@ static int ext4_has_free_blocks(struct e
EXT4_FREEBLOCKS_WATERMARK) {
free_blocks = percpu_counter_sum_positive(fbc);
dirty_blocks = percpu_counter_sum_positive(dbc);
- if (dirty_blocks < 0) {
- printk(KERN_CRIT "Dirty block accounting "
- "went wrong %lld\n",
- (long long)dirty_blocks);
- }
}
/* Check whether we have space after
* accounting for current dirty blocks & root reserved blocks.
next reply other threads:[~2011-04-14 2:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-14 2:10 Shaohua Li [this message]
2011-04-15 4:16 ` [PATCH]ext4: delete dead code Tejun Heo
2011-04-18 0:19 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302747032.3981.181.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox