From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48785CCA479 for ; Wed, 13 Jul 2022 12:25:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235870AbiGMMZ5 (ORCPT ); Wed, 13 Jul 2022 08:25:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235645AbiGMMZq (ORCPT ); Wed, 13 Jul 2022 08:25:46 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9948CE5849 for ; Wed, 13 Jul 2022 05:25:42 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id m16so13850202edb.11 for ; Wed, 13 Jul 2022 05:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linbit-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qXqGFu8U4gPDVSr/ggPX1zJdQr5HzeAZdYNrxVaBP2U=; b=vTibGfqb8AoB8dfwXHh8bxVf5FbFeYJTrOLebeWcAQTsARpBmyHDJEnUnBIrIfttvA r3uR8GsvihZGcnixyJ1ybBzhizpsWGC8XNv0eah0RCuuKzDmiAti20pRwJemgLF+BEVc ehKpt9RsXGhj8HC0ZOoluR+VGr8i6Ga8NNvsMXbCqi6yI57KT9Rt3agP9JXsB/Han+gK zlfO+6gnu5fZbFAJFUVBzLfGv6wM7uLmp/82YfF6L0pZCUM5prM7HSQT6YHfrk27znqQ xp645/qTAw+03mufD09Axo2GVH6ifvt1mOsvsUAtOalPKP2vZRehwNJrzk4M4k10rqJY g68Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qXqGFu8U4gPDVSr/ggPX1zJdQr5HzeAZdYNrxVaBP2U=; b=I31+Ptf493IOzdSdnkqgzog6jFU3exz5vLxQ07AnOrvwUjg4gyTZI9OlcAfZuVbneS NtaI0UNuJ9zCgkImVd9odv3Qly52lIj8L8qtW8qBZ1M2xtBL170b6WgSiEolQc21Ehec NazN7CBGV+w21ADhRfFGcHHKOuzMFydZpAlWVFZftdcTpq7Uu99zsApzBOcAYA67eYg9 tRF5paZNrDQZYH+XCUgXduEzU1/qUvz8oI5zVQpRFJI/KzeBBxK0f1N7u4OCC3sgATsM 1CQ9d423hf9Z2FDYYSVExMdTKHXSuOD7EB4vCysNNHueQeSrC3i2ReXpomBTSAcjWgWo 1Taw== X-Gm-Message-State: AJIora+cdMa/WuOf249y2bqXeCwvsS7AaocyitOHbzwXEWmJj1IMHqQ2 tl1assFD+gq1RsD/g1nv+DD/iw== X-Google-Smtp-Source: AGRyM1t2anjpsABs9moN8/saQwoeQFzlk9BcJwJ81FhrhmrzcGBgnKja0O11XVp6U4a5FFOg06Pmhg== X-Received: by 2002:a05:6402:354c:b0:43a:dc59:657 with SMTP id f12-20020a056402354c00b0043adc590657mr4381358edd.405.1657715140797; Wed, 13 Jul 2022 05:25:40 -0700 (PDT) Received: from [192.168.178.55] (h082218028181.host.wavenet.at. [82.218.28.181]) by smtp.gmail.com with ESMTPSA id k5-20020a17090632c500b0072aa014e852sm4924686ejk.87.2022.07.13.05.25.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 05:25:40 -0700 (PDT) Message-ID: <1304fd58-1577-3f27-0ee8-64964bd54467@linbit.com> Date: Wed, 13 Jul 2022 14:25:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH 3/9] drbd: stop using bdevname in drbd_report_io_error Content-Language: en-US To: Christoph Hellwig Cc: Jens Axboe , "Md. Haris Iqbal" , Jack Wang , Song Liu , Theodore Ts'o , Andreas Dilger , Jan Kara , Mark Fasheh , Joel Becker , Joseph Qi , linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com References: <20220713055317.1888500-1-hch@lst.de> <20220713055317.1888500-4-hch@lst.de> From: =?UTF-8?Q?Christoph_B=c3=b6hmwalder?= In-Reply-To: <20220713055317.1888500-4-hch@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Am 13.07.22 um 07:53 schrieb Christoph Hellwig: > Just use the %pg format specifier instead. > > Signed-off-by: Christoph Hellwig > --- > drivers/block/drbd/drbd_req.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c > index e64bcfba30ef3..6d8dd14458c69 100644 > --- a/drivers/block/drbd/drbd_req.c > +++ b/drivers/block/drbd/drbd_req.c > @@ -523,16 +523,14 @@ static void mod_rq_state(struct drbd_request *req, struct bio_and_error *m, > > static void drbd_report_io_error(struct drbd_device *device, struct drbd_request *req) > { > - char b[BDEVNAME_SIZE]; > - > if (!__ratelimit(&drbd_ratelimit_state)) > return; > > - drbd_warn(device, "local %s IO error sector %llu+%u on %s\n", > + drbd_warn(device, "local %s IO error sector %llu+%u on %pg\n", > (req->rq_state & RQ_WRITE) ? "WRITE" : "READ", > (unsigned long long)req->i.sector, > req->i.size >> 9, > - bdevname(device->ldev->backing_bdev, b)); > + device->ldev->backing_bdev); > } > > /* Helper for HANDED_OVER_TO_NETWORK. For the drbd part: Reviewed-by: Christoph Böhmwalder Thanks. -- Christoph Böhmwalder LINBIT | Keeping the Digital World Running DRBD HA — Disaster Recovery — Software defined Storage