* [PATCH 11/18] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir
[not found] <1305002616-16782-1-git-send-email-sage@newdream.net>
@ 2011-05-10 4:43 ` Sage Weil
2011-05-10 4:43 ` [PATCH 12/18] ext3: " Sage Weil
2011-05-10 4:43 ` [PATCH 13/18] ext2: " Sage Weil
2 siblings, 0 replies; 3+ messages in thread
From: Sage Weil @ 2011-05-10 4:43 UTC (permalink / raw)
To: viro, hch, linux-fsdevel
Cc: Sage Weil, Theodore Ts'o, Andreas Dilger, linux-ext4
ext4 has no problems with lingering references to unlinked directory
inodes.
CC: "Theodore Ts'o" <tytso@mit.edu>
CC: Andreas Dilger <adilger.kernel@dilger.ca>
CC: linux-ext4@vger.kernel.org
Signed-off-by: Sage Weil <sage@newdream.net>
---
fs/ext4/namei.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 792d06e..67fd0b0 100644
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -2123,8 +2123,6 @@ static int ext4_rmdir(struct inode *dir, struct dentry *dentry)
struct ext4_dir_entry_2 *de;
handle_t *handle;
- dentry_unhash(dentry);
-
/* Initialize quotas before so that eventual writes go in
* separate transaction */
dquot_initialize(dir);
@@ -2352,9 +2350,6 @@ static int ext4_rename(struct inode *old_dir, struct dentry *old_dentry,
struct ext4_dir_entry_2 *old_de, *new_de;
int retval, force_da_alloc = 0;
- if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
- dentry_unhash(new_dentry);
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 12/18] ext3: remove unnecessary dentry_unhash on rmdir/rename_dir
[not found] <1305002616-16782-1-git-send-email-sage@newdream.net>
2011-05-10 4:43 ` [PATCH 11/18] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir Sage Weil
@ 2011-05-10 4:43 ` Sage Weil
2011-05-10 4:43 ` [PATCH 13/18] ext2: " Sage Weil
2 siblings, 0 replies; 3+ messages in thread
From: Sage Weil @ 2011-05-10 4:43 UTC (permalink / raw)
To: viro, hch, linux-fsdevel
Cc: Sage Weil, Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4
ext3 has no problems with lingering references to unlinked directory
inodes.
CC: Jan Kara <jack@suse.cz>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Andreas Dilger <adilger.kernel@dilger.ca>
CC: linux-ext4@vger.kernel.org
Signed-off-by: Sage Weil <sage@newdream.net>
---
fs/ext3/namei.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c
index f89b1d4..32f3b86 100644
--- a/fs/ext3/namei.c
+++ b/fs/ext3/namei.c
@@ -2074,8 +2074,6 @@ static int ext3_rmdir (struct inode * dir, struct dentry *dentry)
struct ext3_dir_entry_2 * de;
handle_t *handle;
- dentry_unhash(dentry);
-
/* Initialize quotas before so that eventual writes go in
* separate transaction */
dquot_initialize(dir);
@@ -2298,9 +2296,6 @@ static int ext3_rename (struct inode * old_dir, struct dentry *old_dentry,
struct ext3_dir_entry_2 * old_de, * new_de;
int retval, flush_file = 0;
- if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
- dentry_unhash(new_dentry);
-
dquot_initialize(old_dir);
dquot_initialize(new_dir);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 13/18] ext2: remove unnecessary dentry_unhash on rmdir/rename_dir
[not found] <1305002616-16782-1-git-send-email-sage@newdream.net>
2011-05-10 4:43 ` [PATCH 11/18] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir Sage Weil
2011-05-10 4:43 ` [PATCH 12/18] ext3: " Sage Weil
@ 2011-05-10 4:43 ` Sage Weil
2 siblings, 0 replies; 3+ messages in thread
From: Sage Weil @ 2011-05-10 4:43 UTC (permalink / raw)
To: viro, hch, linux-fsdevel; +Cc: Sage Weil, Jan Kara, linux-ext4
ext2 has no problems with lingering references to unlinked directory
inodes.
CC: Jan Kara <jack@suse.cz>
CC: linux-ext4@vger.kernel.org
Signed-off-by: Sage Weil <sage@newdream.net>
---
fs/ext2/namei.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/fs/ext2/namei.c b/fs/ext2/namei.c
index 516c31d..ed5c5d4 100644
--- a/fs/ext2/namei.c
+++ b/fs/ext2/namei.c
@@ -296,8 +296,6 @@ static int ext2_rmdir (struct inode * dir, struct dentry *dentry)
struct inode * inode = dentry->d_inode;
int err = -ENOTEMPTY;
- dentry_unhash(dentry);
-
if (ext2_empty_dir(inode)) {
err = ext2_unlink(dir, dentry);
if (!err) {
@@ -320,9 +318,6 @@ static int ext2_rename (struct inode * old_dir, struct dentry * old_dentry,
struct ext2_dir_entry_2 * old_de;
int err = -ENOENT;
- if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
- dentry_unhash(new_dentry);
^ permalink raw reply related [flat|nested] 3+ messages in thread