From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH] ext4:Fix a bug in 6d9c85eb.
Date: Tue, 10 May 2011 19:31:57 +0800 [thread overview]
Message-ID: <1305027117-936-1-git-send-email-xiaoqiangnk@gmail.com> (raw)
In case blocksize < pagesize, ext4_ext_fiemap_cb need to ignore
blocks which are not in request range.
BUG description:
xfstests 225 ended in a endless loop without this patch
when blocksize < pagesize.
Reported-by: Amir Goldstein <amir73il@users.sf.net>
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/extents.c | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index e363f21..ec37109 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3718,9 +3718,14 @@ out:
bh = head;
do {
+ if (end < newex->ec_block)
+ /* The buffer is not in
+ * the request range.
+ */
+ continue;
if (buffer_mapped(bh)) {
/* get the 1st mapped buffer. */
- if (end > newex->ec_block +
+ if (end >= newex->ec_block +
newex->ec_len)
/* The buffer is out of
* the request range.
--
1.7.5.1
next reply other threads:[~2011-05-10 11:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 11:31 Yongqiang Yang [this message]
2011-05-10 12:34 ` [PATCH] ext4:Fix a bug in 6d9c85eb Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305027117-936-1-git-send-email-xiaoqiangnk@gmail.com \
--to=xiaoqiangnk@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox