Re: [patch]check NULL pointer

Lukas Czerner
2011-06-09T09:24:50Z

On Thu, 9 Jun 2011, Shaohua Li wrote:

> orig_data could be NULL.

Now, that is the commit description :). Could you please be more
descriptive in the "descritpion" ? Also the subject is not right either,
please see Documentation/SubmittingPatches

Thanks!
-Lukas

>
> Signed-off-by: Shaohua Li <shaohua.li@intel.com>
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index cc5c157..45fc255 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -3057,6 +3057,8 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent)
> unsigned int journal_ioprio = DEFAULT_JOURNAL_IOPRIO;
> ext4_group_t first_not_zeroed;
>
> + if (!orig_data)
> + return ret;

Again no data, no reason for backing off.

> sbi = kzalloc(sizeof(*sbi), GFP_KERNEL);
> if (!sbi)
> goto out_free_orig;
> @@ -4285,6 +4287,8 @@ static int ext4_remount(struct super_block *sb, int *flags, char *data)
> #endif
> char *orig_data = kstrdup(data, GFP_KERNEL);
>
> + if (!orig_data)
> + return -ENOMEM;

This does not seem right, it there is no data we will end with ENOMEM
for no reason.

> /* Store the original options */
> lock_super(sb);
> old_sb_flags = sb->s_flags;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--