From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, jack@suse.cz, sandeen@redhat.com,
Lukas Czerner <lczerner@redhat.com>
Subject: [PATCH] ext4: Deprecate data=journal mount option
Date: Mon, 27 Jun 2011 17:37:24 +0200 [thread overview]
Message-ID: <1309189044-21791-1-git-send-email-lczerner@redhat.com> (raw)
Data journalling mode (data=journal) is known to be neglected by
developers and only minority of people is actually using it. This
mode is also less tested than the other two modes by the developers.
This creates a dangerous combination, because the option which seems
*safer* is actually less safe the others. So this commit adds a warning
message in case that data=journal mode is used, so the user is informed
that the mode has been deprecated and we do not recommend using it.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
fs/ext4/super.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9ea71aa..d5a3dea 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1631,6 +1631,10 @@ static int parse_options(char *options, struct super_block *sb,
sbi->s_min_batch_time = option;
break;
case Opt_data_journal:
+ ext4_msg(sb, KERN_WARNING,
+ "Using data=journal is not recommended. It "
+ "has been deprecated and can be removed "
+ "in the future");
data_opt = EXT4_MOUNT_JOURNAL_DATA;
goto datacheck;
case Opt_data_ordered:
--
1.7.4.4
next reply other threads:[~2011-06-27 15:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 15:37 Lukas Czerner [this message]
2011-06-27 16:48 ` [PATCH] ext4: Deprecate data=journal mount option Andreas Dilger
2011-06-27 17:56 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309189044-21791-1-git-send-email-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox