linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ext4: quiet 'unused variables' compiling warnings
@ 2011-06-28  1:28 Yongqiang Yang
  2011-06-28  9:33 ` Lukas Czerner
  0 siblings, 1 reply; 2+ messages in thread
From: Yongqiang Yang @ 2011-06-28  1:28 UTC (permalink / raw)
  To: tytso; +Cc: linux-ext4, Yongqiang Yang

Unused variables was deleted.

Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
 fs/ext4/extents.c |    2 --
 fs/ext4/mballoc.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index f815cc8..94940aa 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -3107,12 +3107,10 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle,
 					      struct ext4_ext_path *path)
 {
 	struct ext4_extent *ex;
-	struct ext4_extent_header *eh;
 	int depth;
 	int err = 0;
 
 	depth = ext_depth(inode);
-	eh = path[depth].p_hdr;
 	ex = path[depth].p_ext;
 
 	ext_debug("ext4_convert_unwritten_extents_endio: inode %lu, logical"
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 6ed859d..389386b 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -4666,12 +4666,10 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb,
 	struct ext4_buddy e4b;
 	int err = 0, ret, blk_free_count;
 	ext4_grpblk_t blocks_freed;
-	struct ext4_group_info *grp;
 
 	ext4_debug("Adding block(s) %llu-%llu\n", block, block + count - 1);
 
 	ext4_get_group_no_and_offset(sb, block, &block_group, &bit);
-	grp = ext4_get_group_info(sb, block_group);
 	/*
 	 * Check to see if we are freeing blocks across a group
 	 * boundary.
-- 
1.7.5.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ext4: quiet 'unused variables' compiling warnings
  2011-06-28  1:28 [PATCH v2] ext4: quiet 'unused variables' compiling warnings Yongqiang Yang
@ 2011-06-28  9:33 ` Lukas Czerner
  0 siblings, 0 replies; 2+ messages in thread
From: Lukas Czerner @ 2011-06-28  9:33 UTC (permalink / raw)
  To: Yongqiang Yang; +Cc: tytso, linux-ext4

On Tue, 28 Jun 2011, Yongqiang Yang wrote:

> Unused variables was deleted.
> 
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
> ---
>  fs/ext4/extents.c |    2 --
>  fs/ext4/mballoc.c |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index f815cc8..94940aa 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -3107,12 +3107,10 @@ static int ext4_convert_unwritten_extents_endio(handle_t *handle,
>  					      struct ext4_ext_path *path)
>  {
>  	struct ext4_extent *ex;
> -	struct ext4_extent_header *eh;
>  	int depth;
>  	int err = 0;
>  
>  	depth = ext_depth(inode);
> -	eh = path[depth].p_hdr;
>  	ex = path[depth].p_ext;
>  
>  	ext_debug("ext4_convert_unwritten_extents_endio: inode %lu, logical"
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 6ed859d..389386b 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -4666,12 +4666,10 @@ void ext4_add_groupblocks(handle_t *handle, struct super_block *sb,
>  	struct ext4_buddy e4b;
>  	int err = 0, ret, blk_free_count;
>  	ext4_grpblk_t blocks_freed;
> -	struct ext4_group_info *grp;
>  
>  	ext4_debug("Adding block(s) %llu-%llu\n", block, block + count - 1);
>  
>  	ext4_get_group_no_and_offset(sb, block, &block_group, &bit);
> -	grp = ext4_get_group_info(sb, block_group);
>  	/*
>  	 * Check to see if we are freeing blocks across a group
>  	 * boundary.
> 

Patch looks good. Thanks!
-Lukas

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-06-28  9:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-28  1:28 [PATCH v2] ext4: quiet 'unused variables' compiling warnings Yongqiang Yang
2011-06-28  9:33 ` Lukas Czerner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).