linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Czerner <lczerner@redhat.com>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, jack@suse.cz, sandeen@redhat.com,
	adilger@dilger.ca, Lukas Czerner <lczerner@redhat.com>
Subject: [PATCH v2] ext4: Deprecate data=journal mount option
Date: Tue, 28 Jun 2011 13:26:03 +0200	[thread overview]
Message-ID: <1309260363-19012-1-git-send-email-lczerner@redhat.com> (raw)

Data journalling mode (data=journal) is known to be neglected by
developers and only minority of people is actually using it. This
mode is also less tested than the other two modes by the developers.

This creates a dangerous combination, because the option which seems
*safer* is actually less safe the others. So this commit adds a warning
message in case that data=journal mode is used, so the user is informed
that the mode might be removed in the future.

Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
 fs/ext4/super.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 9ea71aa..9d189cf 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1631,6 +1631,11 @@ static int parse_options(char *options, struct super_block *sb,
 			sbi->s_min_batch_time = option;
 			break;
 		case Opt_data_journal:
+			ext4_msg(sb, KERN_WARNING,
+				 "Using data=journal may be removed in the "
+				 "future. Please, contact "
+				 "linux-ext4@vger.kernel.org if you are "
+				 "using this feature.");
 			data_opt = EXT4_MOUNT_JOURNAL_DATA;
 			goto datacheck;
 		case Opt_data_ordered:
-- 
1.7.4.4


             reply	other threads:[~2011-06-28 11:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-28 11:26 Lukas Czerner [this message]
2011-06-29  4:49 ` [PATCH v2] ext4: Deprecate data=journal mount option Bruce Guenter
2011-06-29 11:49   ` Lukas Czerner
2011-08-11 15:01 ` Lukas Czerner
2011-08-11 21:08   ` Andreas Dilger
2011-08-12  8:16     ` Lukas Czerner
2011-08-12  8:25       ` Ric Wheeler
2011-08-12 15:45         ` Curt Wohlgemuth
2011-08-12 16:08           ` Lukas Czerner
2011-08-12 18:13             ` Ted Ts'o
2011-08-12 20:57               ` Christoph Hellwig
2011-08-14  2:06                 ` Ted Ts'o
2011-08-14  2:28                   ` [PATCH] ext2,ext3,ext4: don't inherit APPEND_FL or IMMUTABLE_FL for new inodes Theodore Ts'o
2011-12-22 18:06                     ` Eric Sandeen
2011-12-22 18:19                       ` Ted Ts'o
2011-12-22 18:23                         ` Eric Sandeen
2011-08-15 11:19                   ` [PATCH v2] ext4: Deprecate data=journal mount option Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1309260363-19012-1-git-send-email-lczerner@redhat.com \
    --to=lczerner@redhat.com \
    --cc=adilger@dilger.ca \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sandeen@redhat.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).