From: Tao Ma <tm@tao.ma>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu
Subject: [PATCH] ext4: Don't increase s_mb_buddies_generated in ext4_mb_release.
Date: Sun, 17 Jul 2011 23:11:22 +0800 [thread overview]
Message-ID: <1310915483-2906-2-git-send-email-tm@tao.ma> (raw)
In-Reply-To: <1310915483-2906-1-git-send-email-tm@tao.ma>
From: Tao Ma <boyu.mt@taobao.com>
In ext4_mb_release, we use s_mb_buddies_generated++. Although
the output is OK, but I don't think we need this extra ++.
Signed-off-by: Tao Ma <boyu.mt@taobao.com>
---
fs/ext4/mballoc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index e7749b7..f56a592 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -2568,7 +2568,7 @@ int ext4_mb_release(struct super_block *sb)
atomic_read(&sbi->s_mb_lost_chunks));
printk(KERN_INFO
"EXT4-fs: mballoc: %lu generated and it took %Lu\n",
- sbi->s_mb_buddies_generated++,
+ sbi->s_mb_buddies_generated,
sbi->s_mb_generation_time);
printk(KERN_INFO
"EXT4-fs: mballoc: %u preallocated, %u discarded\n",
--
1.7.4
next prev parent reply other threads:[~2011-07-17 15:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-17 15:11 [PATCH] ext4: Remove unnecessary ext4_get_group_info in ext4_mb_load_buddy Tao Ma
2011-07-17 15:11 ` Tao Ma [this message]
2011-07-23 20:20 ` [PATCH] ext4: Don't increase s_mb_buddies_generated in ext4_mb_release Ted Ts'o
2011-07-17 15:11 ` [PATCH] ext4: Remove ac_repeats from ext4_allocation_context Tao Ma
2011-07-23 20:20 ` Ted Ts'o
2011-07-23 20:19 ` [PATCH] ext4: Remove unnecessary ext4_get_group_info in ext4_mb_load_buddy Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310915483-2906-2-git-send-email-tm@tao.ma \
--to=tm@tao.ma \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).