From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: aedilger@gmail.com, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH 10/12] ext4: remove lock_buffer in bclean() and setup_new_group_blocks
Date: Mon, 18 Jul 2011 10:52:33 +0800 [thread overview]
Message-ID: <1310957555-15617-11-git-send-email-xiaoqiangnk@gmail.com> (raw)
In-Reply-To: <1310957555-15617-1-git-send-email-xiaoqiangnk@gmail.com>
Nobody touchs blocks beyond the filesystem, there is no need to lock
the buffers.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/resize.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index ac5b63d..e452bee 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -157,10 +157,8 @@ static struct buffer_head *bclean(handle_t *handle, struct super_block *sb,
brelse(bh);
bh = ERR_PTR(err);
} else {
- lock_buffer(bh);
memset(bh->b_data, 0, sb->s_blocksize);
set_buffer_uptodate(bh);
- unlock_buffer(bh);
}
return bh;
@@ -239,10 +237,8 @@ static int setup_new_group_blocks(struct super_block *sb,
brelse(gdb);
goto exit_journal;
}
- lock_buffer(gdb);
memcpy(gdb->b_data, sbi->s_group_desc[i]->b_data, gdb->b_size);
set_buffer_uptodate(gdb);
- unlock_buffer(gdb);
err = ext4_handle_dirty_metadata(handle, NULL, gdb);
if (unlikely(err)) {
brelse(gdb);
--
1.7.5.1
next prev parent reply other threads:[~2011-07-18 2:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 2:52 prevent parallel resizers and fix some error handling in resize Yongqiang Yang
2011-07-18 2:52 ` [PATCH 01/12] ext4: prevent parallel resizers by atomic bit ops Yongqiang Yang
2011-07-18 2:52 ` [PATCH 02/12] ext4: prevent a fs with errors from being resized Yongqiang Yang
2011-07-18 2:52 ` [PATCH 03/12] ext4: prevent a fs without journal " Yongqiang Yang
2011-07-18 3:17 ` Tao Ma
2011-07-18 3:28 ` Yongqiang Yang
2011-07-18 3:44 ` Yongqiang Yang
2011-07-18 7:00 ` Andreas Dilger
2011-07-18 2:52 ` [PATCH 04/12] ext4: rename ext4_add_groupblocks() to ext4_group_add_blocks() Yongqiang Yang
2011-07-18 6:32 ` Amir Goldstein
2011-07-18 10:15 ` Yongqiang Yang
2011-07-18 2:52 ` [PATCH 05/12] ext4: let ext4_group_add_blocks return an error code Yongqiang Yang
2011-07-18 6:19 ` Andreas Dilger
2011-07-18 6:47 ` Amir Goldstein
2011-07-18 6:48 ` Amir Goldstein
2011-07-18 12:55 ` Yongqiang Yang
2011-07-18 2:52 ` [PATCH 06/12] ext4: let ext4_group_add_blocks() handle 0 blocks quickly Yongqiang Yang
2011-07-18 2:52 ` [PATCH 07/12] ext4: fix a typo in ext4_group_extend() Yongqiang Yang
2011-07-18 2:52 ` [PATCH 08/12] ext4: let setup_new_group_blocks set multi-bits each time Yongqiang Yang
2011-07-18 6:26 ` Andreas Dilger
2011-07-18 6:56 ` Amir Goldstein
2011-07-18 2:52 ` [PATCH 09/12] ext4: simplify journal handling in ext4_setup_new_group_blocks Yongqiang Yang
2011-07-18 3:09 ` Tao Ma
2011-07-18 3:21 ` Yongqiang Yang
2011-07-18 3:40 ` Tao Ma
2011-07-18 3:46 ` Yongqiang Yang
2011-07-18 2:52 ` Yongqiang Yang [this message]
2011-07-18 2:52 ` [PATCH 11/12] ext4: simplify parameters of add_new_gdb() Yongqiang Yang
2011-07-18 6:46 ` Andreas Dilger
2011-07-18 2:52 ` [PATCH 12/12] ext4: simplify parameters of reserve_backup_gdb() Yongqiang Yang
2011-07-18 7:12 ` Amir Goldstein
2011-07-18 6:16 ` prevent parallel resizers and fix some error handling in resize Amir Goldstein
2011-07-18 10:16 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310957555-15617-11-git-send-email-xiaoqiangnk@gmail.com \
--to=xiaoqiangnk@gmail.com \
--cc=aedilger@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).