From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: aedilger@gmail.com, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH 12/12] ext4: simplify parameters of reserve_backup_gdb()
Date: Mon, 18 Jul 2011 10:52:35 +0800 [thread overview]
Message-ID: <1310957555-15617-13-git-send-email-xiaoqiangnk@gmail.com> (raw)
In-Reply-To: <1310957555-15617-1-git-send-email-xiaoqiangnk@gmail.com>
reserve_backup_gdb() only needs the no. of a group, there is no need to pass
a pointer to struct ext4_new_group_data to it.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/resize.c | 12 +++++++-----
1 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 52d0426..3e790ad 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -556,7 +556,7 @@ exit_bh:
* backup GDT blocks are stored in their reserved primary GDT block.
*/
static int reserve_backup_gdb(handle_t *handle, struct inode *inode,
- struct ext4_new_group_data *input)
+ ext4_group_t group)
{
struct super_block *sb = inode->i_sb;
int reserved_gdb =le16_to_cpu(EXT4_SB(sb)->s_es->s_reserved_gdt_blocks);
@@ -627,7 +627,7 @@ static int reserve_backup_gdb(handle_t *handle, struct inode *inode,
* Finally we can add each of the reserved backup GDT blocks from
* the new group to its reserved primary GDT block.
*/
- blk = input->group * EXT4_BLOCKS_PER_GROUP(sb);
+ blk = group * EXT4_BLOCKS_PER_GROUP(sb);
for (i = 0; i < reserved_gdb; i++) {
int err2;
data = (__le32 *)primary[i]->b_data;
@@ -841,9 +841,11 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input)
if ((err = ext4_journal_get_write_access(handle, primary)))
goto exit_journal;
- if (reserved_gdb && ext4_bg_num_gdb(sb, input->group) &&
- (err = reserve_backup_gdb(handle, inode, input)))
- goto exit_journal;
+ if (reserved_gdb && ext4_bg_num_gdb(sb, input->group)) {
+ err = reserve_backup_gdb(handle, inode, input->group);
+ if (err)
+ goto exit_journal;
+ }
} else {
err = add_new_gdb(handle, inode, input->group);
if (err)
--
1.7.5.1
next prev parent reply other threads:[~2011-07-18 2:57 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 2:52 prevent parallel resizers and fix some error handling in resize Yongqiang Yang
2011-07-18 2:52 ` [PATCH 01/12] ext4: prevent parallel resizers by atomic bit ops Yongqiang Yang
2011-07-18 2:52 ` [PATCH 02/12] ext4: prevent a fs with errors from being resized Yongqiang Yang
2011-07-18 2:52 ` [PATCH 03/12] ext4: prevent a fs without journal " Yongqiang Yang
2011-07-18 3:17 ` Tao Ma
2011-07-18 3:28 ` Yongqiang Yang
2011-07-18 3:44 ` Yongqiang Yang
2011-07-18 7:00 ` Andreas Dilger
2011-07-18 2:52 ` [PATCH 04/12] ext4: rename ext4_add_groupblocks() to ext4_group_add_blocks() Yongqiang Yang
2011-07-18 6:32 ` Amir Goldstein
2011-07-18 10:15 ` Yongqiang Yang
2011-07-18 2:52 ` [PATCH 05/12] ext4: let ext4_group_add_blocks return an error code Yongqiang Yang
2011-07-18 6:19 ` Andreas Dilger
2011-07-18 6:47 ` Amir Goldstein
2011-07-18 6:48 ` Amir Goldstein
2011-07-18 12:55 ` Yongqiang Yang
2011-07-18 2:52 ` [PATCH 06/12] ext4: let ext4_group_add_blocks() handle 0 blocks quickly Yongqiang Yang
2011-07-18 2:52 ` [PATCH 07/12] ext4: fix a typo in ext4_group_extend() Yongqiang Yang
2011-07-18 2:52 ` [PATCH 08/12] ext4: let setup_new_group_blocks set multi-bits each time Yongqiang Yang
2011-07-18 6:26 ` Andreas Dilger
2011-07-18 6:56 ` Amir Goldstein
2011-07-18 2:52 ` [PATCH 09/12] ext4: simplify journal handling in ext4_setup_new_group_blocks Yongqiang Yang
2011-07-18 3:09 ` Tao Ma
2011-07-18 3:21 ` Yongqiang Yang
2011-07-18 3:40 ` Tao Ma
2011-07-18 3:46 ` Yongqiang Yang
2011-07-18 2:52 ` [PATCH 10/12] ext4: remove lock_buffer in bclean() and setup_new_group_blocks Yongqiang Yang
2011-07-18 2:52 ` [PATCH 11/12] ext4: simplify parameters of add_new_gdb() Yongqiang Yang
2011-07-18 6:46 ` Andreas Dilger
2011-07-18 2:52 ` Yongqiang Yang [this message]
2011-07-18 7:12 ` [PATCH 12/12] ext4: simplify parameters of reserve_backup_gdb() Amir Goldstein
2011-07-18 6:16 ` prevent parallel resizers and fix some error handling in resize Amir Goldstein
2011-07-18 10:16 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310957555-15617-13-git-send-email-xiaoqiangnk@gmail.com \
--to=xiaoqiangnk@gmail.com \
--cc=aedilger@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).