* [PATCH] ext4: let ext4_init_inode_table() handle errors right
@ 2011-07-21 14:45 Yongqiang Yang
2011-08-01 10:33 ` Ted Ts'o
0 siblings, 1 reply; 2+ messages in thread
From: Yongqiang Yang @ 2011-07-21 14:45 UTC (permalink / raw)
To: linux-ext4; +Cc: tytso, Yongqiang Yang
This patch lets ext4_init_inode_table() handle errors right.
ext4_init_inode_table() should down_write() alloc_sem which
has been up_write()ed and stop the started journal handle.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/ialloc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
index 21bb2f6..9c63f27 100644
--- a/fs/ext4/ialloc.c
+++ b/fs/ext4/ialloc.c
@@ -1287,7 +1287,7 @@ extern int ext4_init_inode_table(struct super_block *sb, ext4_group_t group,
group, used_blks,
ext4_itable_unused_count(sb, gdp));
ret = 1;
- goto out;
+ goto err_out;
}
blk = ext4_inode_table(sb, gdp) + used_blks;
--
1.7.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: let ext4_init_inode_table() handle errors right
2011-07-21 14:45 [PATCH] ext4: let ext4_init_inode_table() handle errors right Yongqiang Yang
@ 2011-08-01 10:33 ` Ted Ts'o
0 siblings, 0 replies; 2+ messages in thread
From: Ted Ts'o @ 2011-08-01 10:33 UTC (permalink / raw)
To: Yongqiang Yang; +Cc: linux-ext4
On Thu, Jul 21, 2011 at 10:45:07PM +0800, Yongqiang Yang wrote:
> This patch lets ext4_init_inode_table() handle errors right.
> ext4_init_inode_table() should down_write() alloc_sem which
> has been up_write()ed and stop the started journal handle.
>
> Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
Thanks, added to the ext4 patch tree.
- Ted
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-01 10:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-21 14:45 [PATCH] ext4: let ext4_init_inode_table() handle errors right Yongqiang Yang
2011-08-01 10:33 ` Ted Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).