From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>, xfs@oss.sgi.com
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm
Date: Thu, 21 Jul 2011 19:52:04 -0400 [thread overview]
Message-ID: <1311292324-4348-3-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1311292324-4348-1-git-send-email-tytso@mit.edu>
The value of $(LIBDM) may be a linker specification -ldm, and not a
file. So it's not OK to add this to the dependency, since make will
then complain that it doesn't know how to make the target -ldm.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
dmapi/src/common/cmd/Makefile | 2 +-
dmapi/src/sample_hsm/Makefile | 2 +-
dmapi/src/suite1/cmd/Makefile | 2 +-
dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c | 2 +-
dmapi/src/suite2/src/Makefile | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/dmapi/src/common/cmd/Makefile b/dmapi/src/common/cmd/Makefile
index 4b0e550..4525581 100644
--- a/dmapi/src/common/cmd/Makefile
+++ b/dmapi/src/common/cmd/Makefile
@@ -38,7 +38,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
diff --git a/dmapi/src/sample_hsm/Makefile b/dmapi/src/sample_hsm/Makefile
index 7a4ca8c..55df563 100644
--- a/dmapi/src/sample_hsm/Makefile
+++ b/dmapi/src/sample_hsm/Makefile
@@ -38,7 +38,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
diff --git a/dmapi/src/suite1/cmd/Makefile b/dmapi/src/suite1/cmd/Makefile
index 7e51763..05dbead 100644
--- a/dmapi/src/suite1/cmd/Makefile
+++ b/dmapi/src/suite1/cmd/Makefile
@@ -61,7 +61,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
diff --git a/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c b/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
index 6b4d0b6..c01dff0 100644
--- a/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
+++ b/dmapi/src/suite1/cmd/probe_punch_xfsctl_hole.c
@@ -69,7 +69,7 @@ xfsctl_punch_hole(
xfs_flock64_t flock;
int fd;
- if ((fd = open(path, O_RDWR|O_CREAT)) < 0) {
+ if ((fd = open(path, O_RDWR|O_CREAT, 0600)) < 0) {
perror(path);
exit(errno);
}
diff --git a/dmapi/src/suite2/src/Makefile b/dmapi/src/suite2/src/Makefile
index 91a0f00..c5cf6da 100644
--- a/dmapi/src/suite2/src/Makefile
+++ b/dmapi/src/suite2/src/Makefile
@@ -44,7 +44,7 @@ include $(BUILDRULES)
install install-dev: default
-$(TARGETS): $(LLDLIBS)
+$(TARGETS):
@echo " [CC] $@"
$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LDLIBS)
--
1.7.4.1.22.gec8e1.dirty
next prev parent reply other threads:[~2011-07-21 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 23:52 [PATCH XFSTESTS 1/3] configure.in: Declare a requirement for at least autoconf 2.50 Theodore Ts'o
2011-07-21 23:52 ` [PATCH XFSTESTS 2/3] Build without enabling DEBUG by default Theodore Ts'o
2011-07-21 23:52 ` Theodore Ts'o [this message]
2011-07-22 14:29 ` [PATCH XFSTESTS 3/3] dmapi: fix build failure if libdm is provided via -ldm Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1311292324-4348-3-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).