* [PATCH 1/2] ext4: remove redundant argument in mb_find_extent()
@ 2011-08-25 11:36 Robin Dong
2011-08-25 16:28 ` Andreas Dilger
0 siblings, 1 reply; 3+ messages in thread
From: Robin Dong @ 2011-08-25 11:36 UTC (permalink / raw)
To: linux-ext4; +Cc: Ronbin Dong
From: Ronbin Dong <sanbai@taobao.com>
The argument of "ord" in mb_find_extent is not necessary anymore.
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/mballoc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 17a5a57..0702627 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1432,9 +1432,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
break;
- ord = mb_find_order_for_block(e4b, next);
+ order = mb_find_order_for_block(e4b, next);
- order = ord;
block = next >> order;
ex->fe_len += 1 << order;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ext4: remove redundant argument in mb_find_extent()
2011-08-25 11:36 Robin Dong
@ 2011-08-25 16:28 ` Andreas Dilger
0 siblings, 0 replies; 3+ messages in thread
From: Andreas Dilger @ 2011-08-25 16:28 UTC (permalink / raw)
To: Robin Dong; +Cc: linux-ext4, Ronbin Dong
On 2011-08-25, at 5:36 AM, Robin Dong wrote:
> From: Ronbin Dong <sanbai@taobao.com>
>
> The argument of "ord" in mb_find_extent is not necessary anymore.
>
> Signed-off-by: Robin Dong <sanbai@taobao.com>
> ---
> fs/ext4/mballoc.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
This patch doesn't remove the declaration "int ord;" at the start of the function.
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 17a5a57..0702627 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -1432,9 +1432,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
> if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
> break;
>
> - ord = mb_find_order_for_block(e4b, next);
> + order = mb_find_order_for_block(e4b, next);
>
> - order = ord;
> block = next >> order;
> ex->fe_len += 1 << order;
> }
> --
> 1.7.4.1
Cheers, Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/2] ext4: remove redundant argument in mb_find_extent()
@ 2011-08-26 3:17 Robin Dong
0 siblings, 0 replies; 3+ messages in thread
From: Robin Dong @ 2011-08-26 3:17 UTC (permalink / raw)
To: linux-ext4; +Cc: Robin Dong
From: Robin Dong <sanbai@taobao.com>
The argument of "ord" in mb_find_extent is not necessary.
Signed-off-by: Robin Dong <sanbai@taobao.com>
---
fs/ext4/mballoc.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 17a5a57..cc8ed5a 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1390,7 +1390,6 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
{
int next = block;
int max;
- int ord;
void *buddy;
assert_spin_locked(ext4_group_lock_ptr(e4b->bd_sb, e4b->bd_group));
@@ -1432,9 +1431,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
break;
- ord = mb_find_order_for_block(e4b, next);
+ order = mb_find_order_for_block(e4b, next);
- order = ord;
block = next >> order;
ex->fe_len += 1 << order;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-26 3:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-26 3:17 [PATCH 1/2] ext4: remove redundant argument in mb_find_extent() Robin Dong
-- strict thread matches above, loose matches on Subject: below --
2011-08-25 11:36 Robin Dong
2011-08-25 16:28 ` Andreas Dilger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).