linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robin Dong <hao.bigrat@gmail.com>
To: linux-ext4@vger.kernel.org
Cc: Robin Dong <sanbai@taobao.com>
Subject: [PATCH 3/4] ext4: remove unused argument in mb_find_extent
Date: Thu, 15 Sep 2011 15:09:39 +0800	[thread overview]
Message-ID: <1316070580-10723-3-git-send-email-hao.bigrat@gmail.com> (raw)
In-Reply-To: <1316070580-10723-1-git-send-email-hao.bigrat@gmail.com>

From: Robin Dong <sanbai@taobao.com>

The argument 'ord' in function mb_find_extent is redundant,
so remove it.

Signed-off-by: Robin Dong <sanbai@taobao.com>
---
 fs/ext4/mballoc.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index d0fc76e..99d123a 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1390,7 +1390,6 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
 {
 	int next = block;
 	int max;
-	int ord;
 	void *buddy;
 
 	assert_spin_locked(ext4_group_lock_ptr(e4b->bd_sb, e4b->bd_group));
@@ -1432,9 +1431,8 @@ static int mb_find_extent(struct ext4_buddy *e4b, int order, int block,
 		if (mb_test_bit(next, EXT4_MB_BITMAP(e4b)))
 			break;
 
-		ord = mb_find_order_for_block(e4b, next);
+		order = mb_find_order_for_block(e4b, next);
 
-		order = ord;
 		block = next >> order;
 		ex->fe_len += 1 << order;
 	}
-- 
1.7.4.1


  parent reply	other threads:[~2011-09-15  7:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-15  7:09 [PATCH 1/4] ext4: use stream-alloc when mb_group_prealloc set to zero Robin Dong
2011-09-15  7:09 ` [PATCH 2/4] ext4: remove unused argument in ext4_mb_generate_from_pa Robin Dong
2011-10-26  9:24   ` Ted Ts'o
2011-09-15  7:09 ` Robin Dong [this message]
2011-10-26  9:34   ` [PATCH 3/4] ext4: remove unused argument in mb_find_extent Ted Ts'o
2011-09-15  7:09 ` [PATCH 4/4] ext4: fix a wrong comment in __mb_check_buddy Robin Dong
2011-10-26 12:53   ` Ted Ts'o
2011-10-26  9:17 ` [PATCH 1/4] ext4: use stream-alloc when mb_group_prealloc set to zero Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316070580-10723-3-git-send-email-hao.bigrat@gmail.com \
    --to=hao.bigrat@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sanbai@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).