From: Fabrice Jouhaud <yargil@free.fr>
To: linux-ext4@vger.kernel.org
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-kernel@vger.kernel.org, Yargil <yargil@free.fr>
Subject: [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs
Date: Thu, 6 Oct 2011 17:51:16 +0200 [thread overview]
Message-ID: <1317916276-2509-1-git-send-email-yargil@free.fr> (raw)
From: Yargil <yargil@free.fr>
Regression from commit dd68314ccf3fb918c1fb6471817edbc60ece4b52
The problem come from the test of the return value of proc_mkdir
that is always false without procfs and abort the init of ext4.
Signed-off-by: Fabrice Jouhaud <yargil@free.fr>
---
fs/ext4/super.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 44d0c8d..9b51b17 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -4985,8 +4985,10 @@ static int __init ext4_init_fs(void)
if (!ext4_kset)
goto out6;
ext4_proc_root = proc_mkdir("fs/ext4", NULL);
+#ifdef CONFIG_PROC_FS
if (!ext4_proc_root)
goto out5;
+#endif
err = ext4_init_feat_adverts();
if (err)
--
1.7.2.5
next reply other threads:[~2011-10-06 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 15:51 Fabrice Jouhaud [this message]
2011-10-06 16:01 ` [PATCH v3] [SIGNED-OFF] ext4: don't work without procfs Joe Perches
2011-10-06 16:44 ` Ted Ts'o
2011-10-07 8:30 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317916276-2509-1-git-send-email-yargil@free.fr \
--to=yargil@free.fr \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox