From: Theodore Ts'o <tytso@mit.edu>
To: Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-fsdevel@vger.kernel.org
Cc: Theodore Ts'o <tytso@mit.edu>
Subject: [PATCH] fs: optimize out 16 bytes worth of padding in struct inode
Date: Tue, 18 Oct 2011 10:49:15 -0400 [thread overview]
Message-ID: <1318949355-17029-1-git-send-email-tytso@mit.edu> (raw)
Rearrange the fields in struct inode so that on an x86_64 system,
fields that require 8-byte alignment don't end up causing 4-byte holes
in the structure. It reduces the size of struct inode from 568 bytes
to 552 bytes.
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
---
I plan to include this in the next push of ext4 to Linus,
unless there are any objections.
include/linux/fs.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 178cdb4..c85398d 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -775,7 +775,6 @@ struct inode {
struct timespec i_atime;
struct timespec i_mtime;
struct timespec i_ctime;
- unsigned int i_blkbits;
blkcnt_t i_blocks;
#ifdef __NEED_I_SIZE_ORDERED
@@ -785,6 +784,7 @@ struct inode {
/* Misc */
unsigned long i_state;
spinlock_t i_lock; /* i_blocks, i_bytes, maybe i_size */
+ unsigned int i_blkbits;
struct mutex i_mutex;
unsigned long dirtied_when; /* jiffies of first dirtying */
@@ -798,6 +798,7 @@ struct inode {
struct rcu_head i_rcu;
};
atomic_t i_count;
+ atomic_t i_writecount;
u64 i_version;
unsigned short i_bytes;
atomic_t i_dio_count;
@@ -824,7 +825,6 @@ struct inode {
#ifdef CONFIG_IMA
atomic_t i_readcount; /* struct files open RO */
#endif
- atomic_t i_writecount;
void *i_private; /* fs or device private pointer */
};
--
1.7.4.1.22.gec8e1.dirty
reply other threads:[~2011-10-18 14:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318949355-17029-1-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).