From: Yongqiang Yang <xiaoqiangnk@gmail.com>
To: tytso@mit.edu
Cc: linux-ext4@vger.kernel.org, Yongqiang Yang <xiaoqiangnk@gmail.com>
Subject: [PATCH V3 14/15] ext4: let ext4_group_extend() use common code
Date: Tue, 8 Nov 2011 07:13:27 +0800 [thread overview]
Message-ID: <1320707608-14246-15-git-send-email-xiaoqiangnk@gmail.com> (raw)
In-Reply-To: <1320707608-14246-1-git-send-email-xiaoqiangnk@gmail.com>
__ext4_group_extend() is moved out from ext4_group_extend(), this patch
lets ext4_group_extend() call __ext4_group_extentd() instead.
Signed-off-by: Yongqiang Yang <xiaoqiangnk@gmail.com>
---
fs/ext4/resize.c | 41 ++---------------------------------------
1 files changed, 2 insertions(+), 39 deletions(-)
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index ebffc55..a43dcb0 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1804,8 +1804,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es,
ext4_grpblk_t last;
ext4_grpblk_t add;
struct buffer_head *bh;
- handle_t *handle;
- int err, err2;
+ int err;
ext4_group_t group;
o_blocks_count = ext4_blocks_count(es);
@@ -1861,43 +1860,7 @@ int ext4_group_extend(struct super_block *sb, struct ext4_super_block *es,
}
brelse(bh);
- /* We will update the superblock, one block bitmap, and
- * one group descriptor via ext4_free_blocks().
- */
- handle = ext4_journal_start_sb(sb, 3);
- if (IS_ERR(handle)) {
- err = PTR_ERR(handle);
- ext4_warning(sb, "error %d on journal start", err);
- goto exit_put;
- }
-
- if ((err = ext4_journal_get_write_access(handle,
- EXT4_SB(sb)->s_sbh))) {
- ext4_warning(sb, "error %d on journal write access", err);
- ext4_journal_stop(handle);
- goto exit_put;
- }
- ext4_blocks_count_set(es, o_blocks_count + add);
- ext4_debug("freeing blocks %llu through %llu\n", o_blocks_count,
- o_blocks_count + add);
- /* We add the blocks to the bitmap and set the group need init bit */
- err = ext4_group_add_blocks(handle, sb, o_blocks_count, add);
- ext4_handle_dirty_super(handle, sb);
- ext4_debug("freed blocks %llu through %llu\n", o_blocks_count,
- o_blocks_count + add);
- err2 = ext4_journal_stop(handle);
- if (!err && err2)
- err = err2;
-
- if (err)
- goto exit_put;
next prev parent reply other threads:[~2011-11-08 1:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 23:13 [PATCH V3 0/15] ext4: add new online resize interface Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 01/15] ext4: add a function which extends a group without checking parameters Yongqiang Yang
2011-11-08 7:12 ` Andreas Dilger
2011-11-08 8:37 ` Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 02/15] ext4: add a function which adds a new desc to a fs Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 03/15] ext4: add a function which sets up a new group desc Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 04/15] ext4: add a function which updates super block Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 05/15] ext4: add a structure which will be used by 64bit-resize interface Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 06/15] ext4: add a function which sets up group blocks of a flex groups Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 07/15] ext4: add a function which adds several group descriptors Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 08/15] ext4: add a function which sets up a flex groups each time Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 09/15] ext4: enable ext4_update_super() to handle a flex groups Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 10/15] ext4: pass verify_reserved_gdb() the number of group decriptors Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 11/15] ext4: add a new function which allocates bitmaps and inode tables Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 12/15] ext4: add a new function which adds a flex group to a fs Yongqiang Yang
2011-11-07 23:13 ` [PATCH V3 13/15] ext4: add new online resize interface Yongqiang Yang
2011-11-07 23:13 ` Yongqiang Yang [this message]
2011-11-07 23:13 ` [PATCH V3 15/15] ext4: let ext4_group_add() use common code Yongqiang Yang
2011-11-08 7:06 ` [PATCH V3 0/15] ext4: add new online resize interface Andreas Dilger
2011-11-08 8:38 ` Yongqiang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320707608-14246-15-git-send-email-xiaoqiangnk@gmail.com \
--to=xiaoqiangnk@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).