From: Namjae Jeon <linkinjeon@gmail.com>
To: tytso@mit.edu
Cc: linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org,
Namjae Jeon <linkinjeon@gmail.com>,
Amit Sahrawat <amit.sahrawat83@gmail.com>
Subject: [PATCH] ext4: remove unneeded variable.
Date: Sat, 12 Nov 2011 00:02:24 +0900 [thread overview]
Message-ID: <1321023744-16249-1-git-send-email-linkinjeon@gmail.com> (raw)
ret2 is not needed in ext4_flush_completed_IO().
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
Signed-off-by: Amit Sahrawat <amit.sahrawat83@gmail.com>
---
fs/ext4/fsync.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c
index 00a2cb7..40397ac 100644
--- a/fs/ext4/fsync.c
+++ b/fs/ext4/fsync.c
@@ -81,7 +81,6 @@ int ext4_flush_completed_IO(struct inode *inode)
struct ext4_inode_info *ei = EXT4_I(inode);
unsigned long flags;
int ret = 0;
- int ret2 = 0;
dump_completed_IO(inode);
spin_lock_irqsave(&ei->i_completed_io_lock, flags);
@@ -105,12 +104,10 @@ int ext4_flush_completed_IO(struct inode *inode)
*/
spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
ret = ext4_end_io_nolock(io);
- if (ret < 0)
- ret2 = ret;
spin_lock_irqsave(&ei->i_completed_io_lock, flags);
}
spin_unlock_irqrestore(&ei->i_completed_io_lock, flags);
- return (ret2 < 0) ? ret2 : 0;
+ return (ret < 0) ? ret : 0;
}
/*
--
1.7.4.4
next reply other threads:[~2011-11-11 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 15:02 Namjae Jeon [this message]
2011-11-17 9:45 ` [PATCH] ext4: remove unneeded variable Amit Sahrawat
2011-11-19 20:11 ` Srivatsa S. Bhat
2011-11-19 21:09 ` Srivatsa S. Bhat
2011-11-19 21:53 ` NamJae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321023744-16249-1-git-send-email-linkinjeon@gmail.com \
--to=linkinjeon@gmail.com \
--cc=amit.sahrawat83@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox